Last modified: 2011-04-30 01:16:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20867, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18867 - Enhance CSS styling of image page
Enhance CSS styling of image page
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.14.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-21 17:55 UTC by Robert Hänel
Modified: 2011-04-30 01:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for ImagePage.php (2.52 KB, patch)
2009-05-21 17:55 UTC, Robert Hänel
Details

Description Robert Hänel 2009-05-21 17:55:56 UTC
Created attachment 6143 [details]
Patch for ImagePage.php

Currently it's very difficult to style (or hide) the individual elements of an image description page (file history, file links, metadata and the links for uploading a new version, searching for duplicates etc.) using CSS because these sections of the page are not selectable. 

For example, it's not possible to hide the entire file history section because only the heading and the table can be selected because they have an id attribute, but not the text ("Click on a date/time to view the file as it appeared at that time.") and the links for browsing.

Therefore I have created a small patch which encloses the sections in four new DIV elements with the id's 'mw-filehistory', 'mw-filetools', 'mw-filelinks' and 'mw-filemeta'.

I hope you will find it useful.

Regards,
Robert
Comment 1 Happy-melon 2009-05-22 16:16:45 UTC
This patch doesn't apply cleanly against my r50860; there are quite a few unmarked changes. 
Comment 2 Happy-melon 2009-05-22 16:27:32 UTC
Hell, the second chunk is 40 lines out of place.  This patch is against r48966, at best (in r48966 the affected line in chunk 2 was changed; that'll royally screw things up), and it *still* doesn't apply cleanly to that revision (using my admittedly overly-conservative patch port).  Please patch against a more recent revision.
Comment 3 Siebrand Mazeland 2009-05-22 16:33:08 UTC
Reporter, you indicated that something needs to be done on version 1.14.0. This will not be done; no features will be added to 1.14. Please provide a clean patch as requested in comment 2.
Comment 4 Robert Hänel 2009-05-22 17:08:41 UTC
Sorry, I checked out the wrong version. After getting the latest revision, I see that there have already been changes similar to those intended with my patch. Therefore I will close this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links