Last modified: 2012-10-29 16:39:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20860, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18860 - Special:Emailuser doesn't check whether user's IP is blocked
Special:Emailuser doesn't check whether user's IP is blocked
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.16.x
All All
: Normal major with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ru.wikipedia.org/wiki/User:Wel...
: easy
: 17787 18942 19246 (view as bug list)
Depends on:
Blocks: SWMT
  Show dependency treegraph
 
Reported: 2009-05-21 07:31 UTC by Kalan
Modified: 2012-10-29 16:39 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kalan 2009-05-21 07:31:53 UTC
Users are unable to edit using a blocked IP, but they still can send email that way — the check in SpecialEmailuser.php doesn’t take it into consideration.

According to a Russian Wikipedia checkuser, this breach is being heavily abused (spam et al), so this is somewhat urgent.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-05-21 15:03:21 UTC
We should allow IP blocks to block e-mail as well, if they affect registered users.  Currently you can only block accounts from sending e-mail, not IPs.
Comment 2 Alex Z. 2009-05-21 20:33:28 UTC
Done in r50871.
Comment 3 Alex Z. 2009-05-27 03:36:41 UTC
*** Bug 18942 has been marked as a duplicate of this bug. ***
Comment 4 Nakon 2009-06-16 23:04:58 UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=19246 reports that this functionality has broken
Comment 5 Nakon 2009-06-16 23:05:38 UTC
*** Bug 19246 has been marked as a duplicate of this bug. ***
Comment 6 Alex Z. 2009-06-16 23:39:59 UTC
I can't reproduce that, either on my test wiki, or enwiki.
Comment 7 Nakon 2009-06-16 23:41:22 UTC
(In reply to comment #6)
> I can't reproduce that, either on my test wiki, or enwiki.
> 

Would it possibly be an issue with the rangeblock rather than a single IP block?
Comment 8 Nishkid 2009-06-16 23:44:42 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > I can't reproduce that, either on my test wiki, or enwiki.
> > 
> 
> Would it possibly be an issue with the rangeblock rather than a single IP
> block?
> 

I don't think so. Although the case I highlighted in https://bugzilla.wikimedia.org/show_bug.cgi?id=19246 deals with a rangeblock, I've also encountered the same issues with individual IPs that were previously blocked with e-mail blocked as open proxies. 
Comment 9 OverlordQ 2009-06-17 00:04:43 UTC
Were the emails sent before or after the user accounts had email disabled? 

I notice that if a user is affected by a rangeblock with e-mail disabled, and their username is banned without email disabled, they can still send email. 
Comment 10 Nishkid 2009-06-17 00:08:36 UTC
No, the user accounts were not blocked at the time. Only the underlying IP was blocked with account creation blocked and e-mail blocked. 
Comment 11 Alex Z. 2009-06-17 00:10:24 UTC
I specifically tested it using a rangeblock. I used a /24 on enwiki and a /16
on my test wiki.
I checked in each case that the block_email field was getting set in the
database (it did) then tried to send an email from a non-admin account. In each
case I received the standard block screen. I tested trying to send an email via
the API as well.

Looking on the Toolserver, there are currently at least 78 active blocks in the
88.191.0.0/16 range, most of which are not anon only and only a few of which
block email. Its possible that those blocks are taking precedence when
MediaWiki tries to determine the block settings.
http://p.defau.lt/?9hXXkCU__7ingCaSLu8xVQ
Comment 12 Andrew Garrett 2009-06-17 11:36:02 UTC
Yes, blocks are not cumulative. The most specific block is what will apply to the user.
Comment 13 Nishkid 2009-06-17 12:20:23 UTC
That doesn't appear to be the issue. 88.191.253.150 was covered by the 88.191.0.0/16 rangeblock on May 28, yet a banned user was still able to send an e-mail from an account on June 13. 
Comment 14 Alex Z. 2009-06-17 18:58:12 UTC
(In reply to comment #10)
> No, the user accounts were not blocked at the time. Only the underlying IP was
> blocked with account creation blocked and e-mail blocked. 
> 

http://en.wikipedia.org/w/index.php?title=Special:Log&type=block&page=User:Drill%20you%20like%20an%20ocean
http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=block&user=&page=User%3AYAHOO!Hooligan

Both of these users were blocked without email disabled prior to June 13.
Comment 15 Nishkid 2009-06-17 20:41:51 UTC
(In reply to comment #14)
> (In reply to comment #10)
> > No, the user accounts were not blocked at the time. Only the underlying IP was
> > blocked with account creation blocked and e-mail blocked. 
> > 
> 
> http://en.wikipedia.org/w/index.php?title=Special:Log&type=block&page=User:Drill%20you%20like%20an%20ocean
> http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=block&user=&page=User%3AYAHOO!Hooligan
> 
> Both of these users were blocked without email disabled prior to June 13.
> 

Oh, my mistake. The accounts were indeed blocked, BUT this was before the "prevent e-mail" option was added to the block interface. So, technically, they could still send e-mails.
Comment 16 Aaron Schulz 2009-07-05 21:21:44 UTC
Is this still an issue?
Comment 17 Betacommand 2009-07-15 23:19:05 UTC
email block now addresses this issue
Comment 18 Nakon 2009-08-06 05:02:28 UTC
*** Bug 17787 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links