Last modified: 2012-10-05 04:04:56 UTC
Paraphrasing Tim: * Having two separate files creates an illusion of privilege separation * In theory, AdminSettings.php could be protected using UNIX permissions, but it's never done * It provides no real security to separate the admin user from the command-line user * The web user has DELETE capabilities over MediaWiki tables already, so an attacker can do significant damage already I propose removing the file from future installations, putting the data in LocalSettings.php, and modifying maintenance scripts to use LocalSettings.php (if necessary).
I believe Tim resolved this in rev 51650. Resolving as FIXED.
No, only the requirement for update.php. commandLine.inc still expects AdminSettings to be there. Will be fixed with merge of maintenance-work branch.
Fixed in r52336.
I am looking at RELEASE-NOTES and it says >* (bug 18768) Remove AdminSettings.php from MediaWiki core but svn update says D AdminSettings.sample Shouldn't that be * (bug 18768) Remove AdminSettings.sample from MediaWiki core?
(In reply to comment #4) > I am looking at RELEASE-NOTES and it says > >* (bug 18768) Remove AdminSettings.php from MediaWiki core > but svn update says > D AdminSettings.sample > Shouldn't that be > * (bug 18768) Remove AdminSettings.sample from MediaWiki core? > I guess the idea is that the *requirement* for AdminSettings.php was removed.
Exactly. The idea behind the bug is to remove the concept of "AdminSettings" entirely from the core, as it isn't really needed. Granted, this is only fixed in the maintenance-work branch but not core (Brion reverted the merge in r52340)
Done in r53664.
