Last modified: 2009-12-02 13:38:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20762, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18762 - refreshLinks.php forgets redirects
refreshLinks.php forgets redirects
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-11 05:53 UTC by Dan Jacobson
Modified: 2009-12-02 13:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2009-05-11 05:53:35 UTC
$ php refreshLinks.php --help
says
  --redirects-only : Only fix redirects, not all links
which implies that "all links" includes "redirects".

But it really should be worded
  --redirects-only : Only fix redirects, not all links EXCEPT REDIRECTS

Because without it, refreshLinks.php forgets to also refresh redirects.

This has in turn fooled the author of rebuildall.php into thinking
that he is "rebuilding all".

But to actually rebuild all, one needs
$ php rebuildall.php && php refreshLinks.php --redirects-only

So please fix the behavior of refreshLinks.php to reflect its
documentation (and not the documentation to reflect the behavior!)

By the way, the message "Rebuilding links tables" should add "and
category table". Also metion that table in the documentation too.
And perhaps the same for redirects, as that table does not have the word "links" in its name... which in fact you could use as an excuse to close this bug, but don't do that, as you still wouldn't have fixed the "implies" problem above.
Comment 1 Jure Kajzer 2009-12-02 13:38:16 UTC
fixed in r59658

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links