Last modified: 2014-09-24 01:27:38 UTC
Add an unique CSS class or ID to the tagfilter table row at [[Special:RecentChanges]]: <tr><td class="mw-label"><a href="/wiki/Special:Tags" title="Special:Tags">Tag</a> filter:</td><td class="mw-input"><input name="tagfilter" size="20" value="" /> <input type="submit" value="Go" /></td></tr> That would allow to hide that input field (a whole new line taking space, doesn't float right) for wikis/users where this either isn't needed or not used. Currently an ugly JS hack would have to be used.
Changed Component; main tags functionality is powered by the MW system, Abuse filter just uses it from my understanding.
Oh, the submit button should not be hidden (in second row); thus either move the submit button into the previous table row (best), or just give the tagfilter input the appropriate ID/class.
The actual html (and the place to add classes) is in abuse filter. Not really related to tags.
Updated component.
*** Bug 19568 has been marked as a duplicate of this bug. ***
Created attachment 6571 [details] adds “tag-filter” id In this patch, I just added the id “tag-filter” to the input tag.
Comment on attachment 6571 [details] adds “tag-filter” id This patch is six thousand revisions out of date; adding this functionality is no longer "easy".
Created attachment 8321 [details] New patch to add classes Adds 'tagfilter-form' class to standalone version; adds 'tagfilter-input' to input and 'tagfilter-label' to label. Hiding all three in conjunction hides the tagfilter completely, though the interplay with the Submit button is a tricky one. Classes are cheap, no?
(Oh, and copied and pasted in a GPL header for a file that had none. Hope that's right.)
Jarry1250, I'm sorry -- in the last 9 months, the codebase has changed enough that your patch no longer applies cleanly to trunk. Therefore I'm marking it obsolete and removing the "need-review" and "patch" keywords. If the issue is still one you're interested in fixing, please join us in #mediawiki to check in before renewing and possibly revising your approach. Thanks for the patch nonetheless, and sorry for the delay.
Comment on attachment 8321 [details] New patch to add classes This patch no longer applies to trunk per Rusty Burchfield's automated testing https://docs.google.com/spreadsheet/ccc?key=0Ah_71HHl7qa7dGtvSms3TGpHQU9NU2Y1VmNzUEUteWc .
Created attachment 9849 [details] Revised patch Updated for latest trunk; haven't been able to test but is identical to previous patch, which I was able to test.
r111186 -- had to remove a stray comma so it would work.
r111186 was reverted in the end, will resubmit correct version momentarily.
Okay, new patch: https://gerrit.wikimedia.org/r/#change,3659
Fix merged as part of the afore-linked change (3659), so closing as FIXED again.
https://gerrit.wikimedia.org/r/#change,4494 "It was causing: <b>Notice</b>: Array to string conversion in <b>D:\www\DevWiki\core\includes\actions\HistoryAction.php</b> on line <b>164</b><br />"
