Last modified: 2013-07-24 06:39:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 18654 - EditPage.php needs rewrite
EditPage.php needs rewrite
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.15.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 22102 26312 33461 47158
Blocks: code_quality 18891 18892
  Show dependency treegraph
 
Reported: 2009-05-02 14:34 UTC by Roan Kattouw
Modified: 2013-07-24 06:39 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2009-05-02 14:34:04 UTC
The code in EditPage.php doesn't separate DB and UI logic properly, and desperately needs to be totally rewritten. This lack of separation means, among other things, that calling the API action=edit module internally from a SpecialPage is horribly broken and that the API action=edit code itself is ugly.
Comment 1 Niklas Laxström 2009-05-03 07:30:45 UTC
I'd like to add that customising the edit page, or rather using its components elsewhere is very hard if not impossible.
Comment 2 Happy-melon 2009-05-14 10:50:42 UTC
I might try rewriting it as a special page? [[Special:EditPage]]??  Cf bug18789, bug11456, etc.  Would that have a reasonable likelihood of being implemented if it worked? With the write API now well-developed, anything that breaks from making &action=edit redirect to Special:EditPage *deserves* to break.  We'd need to fix bug18789 for UI consistency, but that shouldn't be too difficult (should probably be implemented in SpecialPage so it can be used by SpecialMovePage, SpecialStabilization, etc etc).
Comment 3 Roan Kattouw 2009-05-14 13:35:42 UTC
(In reply to comment #2)
> I might try rewriting it as a special page? [[Special:EditPage]]??  Cf
> bug18789, bug11456, etc.  Would that have a reasonable likelihood of being
> implemented if it worked? With the write API now well-developed, anything that
> breaks from making &action=edit redirect to Special:EditPage *deserves* to
> break.
Sounds like a plan, as long as such an implementation separates UI and DB logic properly, with the former going into SpecialEditPage.php and the latter in something like Edit.php (the point being that the API should be able to do all its edit stuff through the Edit class without needing the SpecialEditPage class).
Comment 4 Ryan Kaldari 2011-12-19 23:23:18 UTC
Would it also be possible to finally separate section title input from edit summary input? Right now they are both set with the same input, which makes the API syntax confusing.
Comment 5 MZMcBride 2013-07-24 06:39:44 UTC
I don't think reducing technical debt counts as an enhancement request.

Futzing with the bug settings accordingly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links