Last modified: 2014-07-16 08:07:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 18562 - Indicate in output whether an interwiki link is marked local
Indicate in output whether an interwiki link is marked local
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.15.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-23 10:36 UTC by Happy-melon
Modified: 2014-07-16 08:07 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Happy-melon 2009-04-23 10:36:03 UTC
We have a number of different types of links that the parser can generate, which are rendered with different classes:

*[[foo|internal link]]              --> <a>
*[[meta:Foo|interwiki link]]        --> <a class="extiw">
*[[:Fr:Foo|inline interlanguage]]   --> <a class="extiw">
*[[google:Foo|external interwiki]]  --> <a class="extiw">
*[http://www.google.com external]   --> <a class="external text">

There is no distinction between 'local' interwikis or interlanguage links, and 'nonlocal' interwikis. It would be nice if this were the case.  That is, it would be nice if, eg:

*[[foo|internal link]]              --> <a class="internal">
*[[meta:Foo|interwiki link]]        --> <a class="internal extiw">
*[[:Fr:Foo|inline interlanguage]]   --> <a class="internal extiw">
*[[google:Foo|external interwiki]]  --> <a class="external extiw">
*[http://www.google.com external]   --> <a class="external text">

Repurposing the then-somewhat-obscurely-named "extiw" class to indicate the interwiki origin of the link, rather than its nature as a 'local' or 'nonlocal' link.  

This could be tricky because, as far as I can tell (and as the quip from Tim at the top of the screen occasionaly indicates) the evil mess of code in Parser::replaceInternalLinks() doesn't really do anything, it's just cover for the imps that actually do the link processing :D
Comment 1 Brion Vibber 2009-04-29 23:09:33 UTC
There's no need for an "internal" class; it was discarded years ago as a waste of space. Internalness is the default state of a link that's not specified as something else.

If there is any need to mark "internal interwikis" distinctly, this would likely be with an additional class; there would be no particular relation between interwikis and in-wiki links.
Comment 2 Happy-melon 2009-04-29 23:16:44 UTC
I'd think that marking *external* interwikis would be the more logical approach.  I see what you mean about "internal" being redundant.  So I guess this is all we need:

*[[foo|internal link]]              --> <a>
*[[meta:Foo|interwiki link]]        --> <a class="extiw">
*[[:Fr:Foo|inline interlanguage]]   --> <a class="extiw">
*[[google:Foo|external interwiki]]  --> <a class="external extiw">
*[http://www.google.com external]   --> <a class="external text">

Comment 3 MZMcBride 2009-04-30 01:19:25 UTC
Just to summarize, you want:

* [[google:Foo|external interwiki]]  --> <a class="extiw">

to become:

* [[google:Foo|external interwiki]]  --> <a class="external extiw">

Everything else appears to stay the same.
Comment 4 Happy-melon 2009-04-30 07:34:45 UTC
Yes, and ditto for all interwiki links marked with iw_local=0.  Combined with bug11477 this would go a long way towards restoring the semantic meaning of the external link icon. 
Comment 5 Gerrit Notification Bot 2014-07-16 08:05:04 UTC
Change 146711 had a related patch set uploaded by TTO:
Add "external" class to non-local interwiki links

https://gerrit.wikimedia.org/r/146711
Comment 6 Nemo 2014-07-16 08:07:47 UTC
(In reply to Happy-melon from comment #4)
> Combined
> with bug11477 this would go a long way towards restoring the semantic
> meaning of the external link icon.

I disagree that this is a solution for that. If you feel an interwiki link should be an external link, ask for the interwiki prefix to be removed from the interwiki map. I suggest WONTFIX here.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links