Last modified: 2014-03-28 10:24:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20515, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18515 - mediawiki:smw_querytoolarge needs PLURAL support
mediawiki:smw_querytoolarge needs PLURAL support
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Jeroen De Dauw
: easy, i18n
Depends on:
Blocks: messages plural
  Show dependency treegraph
 
Reported: 2009-04-19 09:34 UTC by Purodha Blissenbach
Modified: 2014-03-28 10:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Purodha Blissenbach 2009-04-19 09:34:03 UTC
mediawiki:smw_querytoolarge should be using PLURAL,
depending on the number of items in the list in $1.
Comment 1 Siebrand Mazeland 2009-04-24 22:15:20 UTC
Adding i18n keyword
Comment 2 [[kgh]] 2012-06-09 21:14:11 UTC
There are at least two other messages like this one. I am not sure if PLURAL is possible because this message appears within a "tooltip".
Comment 3 Alex Monk 2012-08-02 16:29:38 UTC
kgh, what are the other messages which need plural? Are you going to patch this?
Comment 4 Nemo 2013-08-09 07:59:31 UTC
(In reply to comment #2)
> There are at least two other messages like this one. I am not sure if PLURAL
> is
> possible because this message appears within a "tooltip".

It's possible, since 1.19. https://www.mediawiki.org/w/index.php?title=Manual:Messages_API#Notes_about_gender.2C_grammar.2C_plural
Comment 5 Nemo 2013-11-19 12:36:04 UTC
Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.
Comment 6 [[kgh]] 2013-11-19 15:39:26 UTC
I forgot about this bug entirely. :|

This message is here [1]. I think the part of the query exceeding the limit is just cut off and displayed as $1. So there is no way to tell if $1 contains one or more omitted conditions. The same applies to the messages "smw_noqueryfeature", "smw_noconjunctions" and "smw_nodisjunctions". Since I am not really competent here this would have to be assessed by a programmer. If this is true, "smw_querytoolarge" should probably be adjusted from

"The following query condition(s) could not be considered due to the wikis restrictions in query size or depth: $1."

to 

"The following query conditions could not be considered due to the wikis restrictions in query size or depth: $1."

If false it should be checked if this message can be transformed to cater for PLURAL in JavaScript for the tooltip. After that the message may be adjusted accordingly as well.

I am reassigning this bug to Jeroen since he will probably to this quite fast if time permits.

[1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FSemanticMediaWiki/b2c9e7c256afbcd49362d380df5321f1b8f39fad/includes%2Fquery%2FSMW_Query.php#L193

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links