Last modified: 2009-04-26 12:37:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20420, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18420 - Missing file revisions should be handled gracefully (delete, move, etc).
Missing file revisions should be handled gracefully (delete, move, etc).
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.15.x
All All
: Normal normal (vote)
: ---
Assigned To: Victor Vasiliev
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-09 18:22 UTC by Splarka
Modified: 2009-04-26 12:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Splarka 2009-04-09 18:22:50 UTC
==Move==
Per https://bugzilla.wikimedia.org/show_bug.cgi?id=15842#c8 image pages were being moved while the associated files were not, in the case of missing old revisions. Vasilvv has fixed this to abort on error, but file moves should gracefully skip missing old revisions when moving, rather than simply fail.

==Delete==
If you delete an image or old version of an image where the associated file is missing, you cannot undelete the image, except by manually de-selecting all broken old versions from the file history.

Deleting old missing revisions results in a successful removal of the row 	with warning:
 Error deleting file: Could not rename file "public/archive/a/a3/20080704135833!AnyNonsense.png" to "deleted/7/g/q/7gqsst5kfvsixebqpajrsf31hczook9.png".

Attempting to undelete a single missing revision results in general errors:
 Undelete failed; someone else may have undeleted the page first.
 Undeletion will not be performed if it will result in the top page or file revision being partially deleted. In such cases, you must uncheck or unhide the newest deleted revision.
 Error undeleting file: Could not find file "deleted/7/g/q/7gqsst5kfvsixebqpajrsf31hczook9.png". 

Attempting to undelete all revisions where one or more versions are missing results in a success message with warnings, and a corrupted page created with no files associated at all (similar to earlier file moving problems):
  Errors were encountered while undeleting the file:
    * Could not find file "deleted/b/x/i/bxik35jpaakpwc8a6i09gq3heevjl0e.png".
    * Could not find file "deleted/7/g/q/7gqsst5kfvsixebqpajrsf31hczook9.png".
Comment 1 Victor Vasiliev 2009-04-26 12:37:22 UTC
Fixed in r49896.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links