Last modified: 2009-04-04 20:06:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20331, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 18331 - MediaWiki:Undelete-revision doesn't render HTML
MediaWiki:Undelete-revision doesn't render HTML
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.15.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-04-03 20:53 UTC by Happy-melon
Modified: 2009-04-04 20:06 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Improve message handling in Special:Undelete. Against r48846 (2.47 KB, patch)
2009-04-04 12:38 UTC, Happy-melon 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Happy-melon 2009-04-03 20:53:59 UTC 
Title says it all: bizzarely, wikimarkup is expanded to HTML, but the HTML is then escaped before display. Not sure what's going on, but it's probably not right.  While in the process of fixing this, could the <hr> that renders on Special:Undelete immediately below that message be moved into the system message so it can be played with, please?
Comment 1 Alexandre Emsenhuber [IAlex] 2009-04-03 21:00:30 UTC 
The message is not parsed (wiki markup expanded to HTML), it's only escaped. Of course this could be changed to allow wiki markup.
Comment 2 Happy-melon 2009-04-03 21:27:00 UTC 
Sort of.  Templates are expanded, as are ParserFunctions, but wikimarkup such as links and '''bold''' are not; then everything is escaped.  This halfway house is actually worse than plaintext.
Comment 3 Happy-melon 2009-04-04 12:38:48 UTC 
Created attachment 5988 [details]
Improve message handling in Special:Undelete.  Against r48846

Simple patch, improves message handling; also moves the <hr> inside a labelled div so it can at least be hidden if desired.
Comment 4 Alexandre Emsenhuber [IAlex] 2009-04-04 20:06:59 UTC 
Applied in r49184 with some modifications:
* had to use wfMsgWikiHtml() since paramters are already full HTML with links
* removed completely the <hr /> since it's redundant with <div class="mw-warning">
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links