Last modified: 2011-04-14 15:14:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20283, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 18283 - CodeReview diff weirdness for branching revs
CodeReview diff weirdness for branching revs
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 19178 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-31 16:10 UTC by Roan Kattouw
Modified: 2011-04-14 15:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2009-03-31 16:10:21 UTC
When viewing revisions that create branches, the diff display should ideally be hidden, but displays error messages instead.

In r49081, a rev resulting from svn mkdir, there is no diff to show, resulting in the "Failed to load diff." error message.

In r49082, a rev resulting from svn copy, the diff would probably be huge, resulting in the "Diff load failed. :(" error message. This one took considerably longer to appear than the previous one.

Of course this isn't a huge issue, but since failures aren't cached, it's wasting resources.
Comment 1 Roan Kattouw 2009-06-13 11:59:48 UTC
*** Bug 19178 has been marked as a duplicate of this bug. ***
Comment 2 Sam Reed (reedy) 2011-03-05 00:04:21 UTC
Wonder if we can create a "list" of non temporary failures. ie there is no diff, so we can just cache that...
Comment 3 Sam Reed (reedy) 2011-03-19 21:27:00 UTC
We have a bit more of a clue of why a diff failed now..

I guess we can cache some as permanent failures (ie it will never load correctly)

	public static function getDiffErrorMessage( $error ) {
		switch( $error ) {
			case self::DIFFRESULT_BadRevision:
				return 'Bad revision specified.';
			case self::DIFFRESULT_TooManyPaths:
				return 'Too many paths returned to diff';
			case self::DIFFRESULT_NoDataReturned:
				return 'No data returned for diff';
			case self::DIFFRESULT_NotInCache:
				return 'Not in cache';
			default:
				return 'Unknown';
		}
	}

But probably some more work needs doing...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links