Last modified: 2011-05-24 23:30:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T20003, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 18003 - action=opensearch documentation in API help shows "format -"
action=opensearch documentation in API help shows "format -"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenSearchXml (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Brion Vibber
http://en.wikipedia.org/w/api.php
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-03-16 15:19 UTC by Sam Reed (reedy)
Modified: 2011-05-24 23:30 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2009-03-16 15:19:10 UTC 
http://en.wikipedia.org/w/api.php

  format         - 


The format bit should be removed or something put at the right hand side of the hyphen!
Comment 1 Roan Kattouw 2009-04-17 09:48:20 UTC 
Resetting back to the extensions component: this bug is in the OpenSearchXML extension, not in core.
Comment 2 Roan Kattouw 2009-05-02 13:40:00 UTC 
Fixed in r50127
Comment 3 Brion Vibber 2009-05-03 22:30:43 UTC 
This looks like it'll hide the parameter instead of documenting it correctly...
Comment 4 Roan Kattouw 2009-05-04 07:04:06 UTC 
(In reply to comment #3)
> This looks like it'll hide the parameter instead of documenting it correctly...
> 
... which is intended, since the parameter was mistakenly overridden from ApiMain.
Comment 5 Brion Vibber 2009-05-05 21:25:18 UTC 
Reverted in r50240.

r50127 changes the default format from json to xmlfm, breaking anything which would have attempted to use standard json search suggestions, such as when $wgEnableMWSuggest is set. I'm guessing breaking the functionality entirely was not intended. :)
Comment 6 Sam Reed (reedy) 2010-03-23 20:22:19 UTC 
Seems it's back to JSON...
Comment 7 Brion Vibber 2011-05-24 23:30:31 UTC 
r88766 should pretty much resolve this on trunk:

* added explicit default, acceptable values list, and description for the parameter so it shows correctly in help
* still not using $this->getMain()->getParameter('format') since this ignores our default -- so still using the same code to manually fetch it.

Added a comment about that bit though, so if someone wants to clean them up in future, spiff.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links