Last modified: 2009-03-15 13:46:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19992, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17992 - r48399 Broke parser tests (maybe other stuff)
r48399 Broke parser tests (maybe other stuff)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.15.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-03-15 13:32 UTC by OverlordQ
Modified: 2009-03-15 13:46 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description OverlordQ 2009-03-15 13:32:22 UTC 
r48399 adds a check to see if the path is writeable before creating, but if the path doesn't exist yet, how can it check to see if it's writable?

It checks the whole path instead of the parents, if the path isn't writable the mkdir will return false anyways, so isn't this check redundant?

CC'ing committer.
Comment 1 Chad H. 2009-03-15 13:46:00 UTC 
Reverted in r48416.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links