Last modified: 2009-03-04 19:18:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19760, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17760 - Allow CSV result format to accommodate large result sets
Allow CSV result format to accommodate large result sets
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Markus Krötzsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-02 18:32 UTC by Joel Natividad
Modified: 2009-03-04 19:18 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to use php://temp instead of php://memory (512 bytes, patch)
2009-03-02 18:32 UTC, Joel Natividad
Details

Description Joel Natividad 2009-03-02 18:32:16 UTC
Created attachment 5876 [details]
patch to use php://temp instead of php://memory

Hi Markus,
There was a discussion on semediawiki-user about CSV result printer limits ( | limit=40000) so I poked around and made a small change. (see http://us.php.net/wrappers.php).

Attached is the proposed patch.

Thanks,
Joel
Comment 1 Joel Natividad 2009-03-03 22:02:47 UTC
Markus,
I went ahead and applied the patch after thorough testing with $smwgQMaxInlineLimit and "| limit" set to large values.
(http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=47994)

Feel free to reverse the commit if need be.

Best,
Joel
Comment 2 Markus Krötzsch 2009-03-04 17:48:39 UTC
Thanks a lot -- I am somewhat busy these weeks, hence the delay in incorporating contributions.

The change looks okay to me, although I vaguely recall that I had some reason for using memory at first. But we can just see how things work out in practice (if nobody complains, I assume that all is well).
Comment 3 Joel Natividad 2009-03-04 19:06:36 UTC
No problem - I suspected as much especially with CeBit underway.  I just wish I could have taken the time to go there for the 2nd SMW UGM but work didn't permit.  Hopefully, arrangements will be made to get SMW users to participate virtually like when you Skyped in Boston.

FWIW, I did some stress testing with big result sets spanning more than 2M (the point, at which PHP starts swapping to the filesystem by default), and even set the swap point (php://temp/maxmemory:NNNbytes) to a ridiculously low number (100 bytes) and it worked without problems.

Comment 4 Markus Krötzsch 2009-03-04 19:18:06 UTC
Ok, great (the tests). I still fear that query result formatting is not particularly memory efficient in the API right now (too much copying, whole result kept for serialization instead of keeping only current slice). I will try to improve this in some future.

Denny and Frank (SRF Graph extension) are at CeBit for demoing SMW, I escaped. Other things are due here, anyway (e.g. the 6th ontolog telco on Semantic Wikis tomorrow; see http://ontolog.cim3.net/cgi-bin/wiki.pl?ConferenceCall_2009_03_05).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links