Last modified: 2010-02-26 20:23:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19560, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 17560 - Half-broken deletion moved image files to deletion archive without updating DB
Half-broken deletion moved image files to deletion archive without updating DB
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Chad H.
http://commons.wikimedia.org/wiki/Fil...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-02-18 21:53 UTC by Brion Vibber
Modified: 2010-02-26 20:23 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2009-02-18 21:53:41 UTC 
Got a report that this image file was missing:
http://commons.wikimedia.org/wiki/File:Nawras_pasha_Al-_Hiraki_With_Sultan.jpg

Confirmed that the file was gone while page and DB entries were intact. Checked the file deletion archive on the file server and found it there:

-rw-r--r--  1 apache apache  26100 Feb 16 18:24 5cwnvlx4dbx3pzhi7religjue3noolu.jpg

I was able to copy the files back into place, restoring the image.

(One current and one old version, both with the same file hash.)


It looks like someone attempted to delete the image and it was moved into the deletion archive and removed from the regular directories, but the database updates did not complete:
* image entry remained
* oldimage entry remained
* page/revision entries remained
* no page deletion info
* no file deletion info
* no logs

This is bad -- we need to ensure that failure scenarios leave the file intact if the DB can't be successfully updated.
Comment 1 Chad H. 2009-11-28 04:41:55 UTC 
Mass component change for merge of "File/Repo" and "Images and Files"
Comment 2 Max Semenik 2010-02-26 20:23:21 UTC 
Fixed in r63018
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links