Last modified: 2009-01-31 20:12:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19267, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17267 - $1 not expanded in namespace aliases in the API
$1 not expanded in namespace aliases in the API
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ast.wikipedia.org/w/api.php?ac...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-31 00:42 UTC by merl
Modified: 2009-01-31 20:12 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description merl 2009-01-31 00:42:00 UTC
On ast.wikipedia.org "$1 discusión" is a namespacealias for the "project talk" namespace. I don't speak that language but "$1" is wrong.
Comment 1 Niklas Laxström 2009-01-31 17:01:24 UTC
There seems to be quite a many cases where $1 (with or without grammar) is used in aliases.

egrep ">\s*NS_PROJECT" languages/messages/*.php | grep '$1' | wc -l
30

Enabled conversion in r46648, but the API still reports unconverted values, reassigning to API for resolution.
Comment 2 Roan Kattouw 2009-01-31 17:59:57 UTC
(In reply to comment #1)
> There seems to be quite a many cases where $1 (with or without grammar) is used
> in aliases.
> 
> egrep ">\s*NS_PROJECT" languages/messages/*.php | grep '$1' | wc -l
> 30
> 
> Enabled conversion in r46648, but the API still reports unconverted values,
> reassigning to API for resolution.
> 

Assigning back and changing summary. The API reports the correct values, it's the i18n/l10n code that's not expanding $1 in namespace aliases here. The API reports "$1 discusión" as an alias for "Uiquipedia alderique" (the Project_talk namespace). This is fully correct, as http://ast.wikipedia.org/wiki/$1_discusión:Foo redirects to http://ast.wikipedia.org/wiki/Uiquipedia_alderique:Foo , whereas http://ast.wikipedia.org/wiki/Uiquipedia_discusi%C3%B3n:Foo is a page in the main namespace (the páxina tab is highlighted rather than the alderique tab).
Comment 3 Niklas Laxström 2009-01-31 18:06:16 UTC
Like I said in my previous commit: Enabled conversion in r46648
Comment 4 Roan Kattouw 2009-01-31 20:04:08 UTC
(In reply to comment #3)
> Like I said in my previous commit: Enabled conversion in r46648
> 

Right, overlooked that. Local testing confirms that r46648 fixed the bug I mentioned but doesn't fix it in the API.
Comment 5 Roan Kattouw 2009-01-31 20:12:45 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Like I said in my previous commit: Enabled conversion in r46648
> > 
> 
> Right, overlooked that. Local testing confirms that r46648 fixed the bug I
> mentioned but doesn't fix it in the API.
> 

Fixed in r46656 by expanding on your fix a little bit.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links