Last modified: 2013-11-22 20:29:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T19180, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 17180 - $wgShowIPinHeader should be implied when using file or squid cache modes
$wgShowIPinHeader should be implied when using file or squid cache modes
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
http://lists.wikimedia.org/pipermail/...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-27 19:11 UTC by Brion Vibber
Modified: 2013-11-22 20:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2009-01-27 19:11:45 UTC
Currently we just silently fail to cache things if $wgShowIPinHeader is on, which it is by default.

This is pretty lame and error-prone, since it's realllly easy not to realize you have to turn off this cosmetic setting to make caching work. I take full responsibility for making it work this way back in the early 2000s, but that was dumb of me. :)

We should just force it to off if eg $wgUseFileCache is in use, since that's the far more interesting/important setting.
Comment 1 Chad H. 2009-01-27 19:53:56 UTC
Done for $wgUseFileCache in r46372
Comment 2 Aaron Schulz 2009-01-27 19:58:46 UTC
Done in r46374 (after edit conflict)
Comment 3 Gerrit Notification Bot 2013-11-21 04:50:10 UTC
Change 96691 had a related patch set uploaded by Persia:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96691
Comment 4 Gerrit Notification Bot 2013-11-21 04:54:12 UTC
Change 96691 abandoned by Persia:
Update comment in DefaultSettings for bug 17180

Reason:
This is the wrong branch name, which is likely to be confusing to reviewers.

https://gerrit.wikimedia.org/r/96691
Comment 5 Gerrit Notification Bot 2013-11-21 04:59:32 UTC
Change 96692 had a related patch set uploaded by Persia:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96692
Comment 6 Gerrit Notification Bot 2013-11-22 20:29:34 UTC
Change 96692 merged by jenkins-bot:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96692

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links