Last modified: 2011-03-13 18:06:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3707, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1707 - Request addition of a '.navbox' CSS class.
Request addition of a '.navbox' CSS class.
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-18 15:41 UTC by grendelkhan
Modified: 2011-03-13 18:06 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Diff to implement the conservative set of features in common.css. (322 bytes, patch)
2005-03-18 17:01 UTC, grendelkhan
Details
Diff to create new .navbox CSS class. (499 bytes, patch)
2005-03-24 19:39 UTC, grendelkhan
Details

Description grendelkhan 2005-03-18 15:41:51 UTC
The 'toccolours' CSS class, as it stands, doesn't fully format the table it's a
part of. This requires markup in the tables, which is suboptimal.

I propose the addition of the following to skins/common/common.css:

.toccolours th {
	background-color:#ccccff;
	text-align:center;
	font-size:normal;
}

This is in concurrence with the standard Wikipedia style for navboxes. (See
[[en:Template:OSIModel]], [[en:Template:Gastroenterology]] and so forth.) This
will allow navboxes to be custom-styled along with the rest of the site, as well
as making it considerably easier to write a properly-styled navbox.
Comment 1 grendelkhan 2005-03-18 16:58:21 UTC
It's tempting to add

.toccolours td {
	font-size:small;
}

but the merits are debatable. On the one hand, the vast majority of navboxes
shrink their contents so that they can fit more in. But on the other hand,
double-smalling the contents would make them illegibly tiny until someone went
through and fixed them all.

On the other hand, doing a 

.toccolours {
	...
	font-size:small;
}

.toccolours th {
	...
	font-size:normal;
}

would allow the user to easily override the table style in instances where small
contents are not in order ({| class="toccolours" style="font-size:normal"). The
small-text problem from above remains, but this would make the shrunken text
inside at least be the default. If there were a way to prevent double-shrinking,
that would be ideal.
Comment 2 grendelkhan 2005-03-18 17:01:39 UTC
Created attachment 371 [details]
Diff to implement the conservative set of features in common.css.

This is a patch to be applied to common.css to implement the first, more
conservative version of this change.
Comment 3 grendelkhan 2005-03-24 19:39:05 UTC
After discussion on [[WP:VP]] (proposals), I've decided to change the request to
ask for a new class entirely, instead of overloading the .toccolours class to do
things it was not originally intended for.

I would like the addition of a .navbox CSS class. In addition to being named for
what it would be used for, the automatic use of small fonts for the inside of
the navbox could be implemented, since the new class would only be used as the
navbox templates were rewritten. A new diff is being attached.
Comment 4 grendelkhan 2005-03-24 19:39:57 UTC
Created attachment 383 [details]
Diff to create new .navbox CSS class.
Comment 5 Zigger 2005-07-10 08:25:16 UTC
Has this been superseded by the changes to the 1.5 navigation lists?
Comment 6 Zigger 2005-07-10 09:13:13 UTC
(In reply to comment #5)
> Has this been superseded by the changes to the 1.5 navigation lists?
In answer to myself: No.  Navboxes are not navigation lists.
Comment 7 Brion Vibber 2005-10-09 07:49:47 UTC
Shouldn't this be in the local site css in the wiki?
Comment 8 Rob Church 2005-10-09 13:27:57 UTC
Agreed; this can be changed depending upon the needs of the wiki itself, via
[[MediaWiki:monobook.css]], [[MediaWiki:classic.css]] et al. Marking WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links