Last modified: 2008-10-18 10:10:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18017, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16017 - cmcontinue breaks with sortkeys containing pipe characters
cmcontinue breaks with sortkeys containing pipe characters
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.14.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-17 22:45 UTC by Roan Kattouw
Modified: 2008-10-18 10:10 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (1.52 KB, patch)
2008-10-18 09:51 UTC, Roan Kattouw
Details

Description Roan Kattouw 2008-10-17 22:45:19 UTC
When a sortkey contains a pipe, the API can return a continuation like:

<query-continue>
 <categorymembers cmcontinue="Bar|Baz|" />
</query-continue>

When using that, the API obviously returns the error message:

<error code="cmbadcontinue" info="Invalid continue param. You should pass the original value returned by the previous query">

The same issue may apply to other modules that use non-title-validated strings in continue parameters (if there are any other ones).
Comment 1 Roan Kattouw 2008-10-18 09:51:42 UTC
Created attachment 5448 [details]
Patch

The attached patch fixes this bug by allowing multiple pipes in cmcontinue; only the last one is treated as a separator.
Comment 2 Alexandre Emsenhuber [IAlex] 2008-10-18 10:10:05 UTC
applied in r42197.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links