Last modified: 2014-07-28 15:54:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17712, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15712 - Error generation of unbalanced <ref><references/>: No error is shown if missing </ref>-tag is the last ref tag
Error generation of unbalanced <ref><references/>: No error is shown if missi...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
unspecified
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 21798 (view as bug list)
Depends on: 6199
Blocks: 16330
  Show dependency treegraph
 
Reported: 2008-09-24 15:18 UTC by Church of emacs
Modified: 2014-07-28 15:54 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Church of emacs 2008-09-24 15:18:00 UTC
If the missing </ref>-tag is the last ref tag, no error message is displayed.
Works correct: <ref>broken <ref>correct</ref> <references />
Doesn't work : <ref>broken <references />

See also https://bugzilla.wikimedia.org/show_bug.cgi?id=6199#c25 for comments on that
Comment 1 John Mark Vandenberg 2011-05-06 11:43:51 UTC
I think this is fixed.
Comment 2 Duncan Harris 2012-01-18 19:48:14 UTC
No this isn't fixed per se:

the sequence "<ref><references/>" generates the error:

"Cite error: Cite error: There are <ref> tags on this page, but the references will not show without a <references/> tag."

But this is the wrong error message because there is indeed a <references/> in the page.  The error should be:

"Cite error: Closing </ref> missing for <ref> tag"

or maybe even:

"Cite error: Closing </ref> missing for last <ref> tag"
Comment 3 Gadget850 2014-07-21 14:51:54 UTC
Duplicate of Bug 21798
Comment 4 James Forrester 2014-07-21 15:43:19 UTC
*** Bug 21798 has been marked as a duplicate of this bug. ***
Comment 5 Jesús Martínez Novo (Ciencia Al Poder) 2014-07-21 16:56:32 UTC
(In reply to Duncan Harris from comment #2)
> the sequence "<ref><references/>" generates the error:
> 
> "Cite error: Cite error: There are <ref> tags on this page, but the
> references will not show without a <references/> tag."
> 
> But this is the wrong error message because there is indeed a <references/>
> in the page.  The error should be:
> 
> "Cite error: Closing </ref> missing for <ref> tag"
> 
> or maybe even:
> 
> "Cite error: Closing </ref> missing for last <ref> tag"

It doesn't output an error message anymore because, apparently because bug 66860 has been resolved and it now just silently eats the error message.
Comment 6 Gadget850 2014-07-21 21:14:01 UTC
If the last </ref> was missing, then the reference list markup would get eaten and it would trigger 'MediaWiki:Cite error refs without references'. On enwiki, this would put the page into an error category and it would be fixed.

Bug 66860 added the automatic reference list, so 'MediaWiki:Cite error refs without references' is never triggered. Instead, the unclosed <ref> eats the following content and includes it in the last rendered reference.

Example:

<ref>1

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.

Bu if the reference list markup exists, then the last reference is generated twice and the the reference list markup is exposed.

Example:

<ref>1

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. 

<references />

There may be other instances where this renders differently.
Comment 7 Gadget850 2014-07-28 15:08:36 UTC
Bumping up importance since we can no longer track and resolve this problem.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links