Last modified: 2010-05-15 16:03:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16966, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14966 - SeachEngineDummy class missing replacePrefixes() function
SeachEngineDummy class missing replacePrefixes() function
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
1.13.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: sqlite
  Show dependency treegraph
 
Reported: 2008-07-28 22:57 UTC by Gerry Riddell
Modified: 2010-05-15 16:03 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gerry Riddell 2008-07-28 22:57:21 UTC
I installed the 1.13.0rc1 code, and set Mediawiki up to use SQLite.  When doing a search off the main page, I would always be presented with the following error:

Fatal error: Call to undefined method SearchEngineDummy::replacePrefixes() in F:\www\Program\www\localhost\wikidev\includes\specials\SpecialSearch.php on line 170

Looked at the SearchEngine class and the SearchEngineDummy class in the  'includes/SearchEngine.php' file.

Looked at the SearchEngineDummy class, confirmed that there was no 'replacePrefixes' function.

Looked at the SearchEngine class, confirmed that there was a 'replacePrefixes' function.

Added empty 'replacePrefixes' function to the SearchEngineDummy class.

Error went away.


I hope this helps, please feel free to ask for additional information if necessary.

 -gerry.
Comment 1 Brion Vibber 2008-07-28 23:48:23 UTC
Looks like there's no good reason to have a SearchEngineDummy class; the SearchEngine base class provides dummy implementations of all the necessary functions itself.

In r38159 (trunk) I've gone ahead and just switched SearchEngineDummy to a null extension of SearchEngine. (The "Dummy" class name is still useful, as it'll be more obvious that you've got a bogus object when debugging. :)

Applied as r38160 on 1.13 branch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links