Last modified: 2014-08-26 03:40:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14530 - Classic edit toolbar should be more accessible for change and modification
Classic edit toolbar should be more accessible for change and modification
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript
: 14808 (view as bug list)
Depends on:
Blocks: edit-toolbar
  Show dependency treegraph
Reported: 2008-06-13 17:26 UTC by Hans-Petter Fjeld
Modified: 2014-08-26 03:40 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Hans-Petter Fjeld 2008-06-13 17:26:27 UTC
As it is now you got the choice between nasty JavaScript-hacks and editing EditPage.php for changing the toolbar-buttons. It would be better if they were accessible through a WM specialpage.
Comment 1 Eugene Zelenko 2008-06-13 17:51:17 UTC
Probably you mean same thing as bug 11732.
Comment 2 Hans-Petter Fjeld 2008-06-13 18:08:11 UTC
That does not appear to be so. bug 11732 talks about different toolbar-buttons for different languages, I just want the buttons more accessible for changes and modifications in general.
Comment 3 Anders Einar Hilden 2008-06-13 19:08:37 UTC
I.e. if you want to change the standard -- (two hyphens) before the signatures created by the current signature button to say, a — (em dash), you have to hack includes/EditPage.php, you can't change it in a page like [[Mediawiki:EditButtons]].
Comment 4 Hans-Petter Fjeld 2008-06-13 20:25:30 UTC
Yes, thats correct. I belive a Mediawiki-specialpage would be better than having to edit the EditPage.php or doing javascript hacks.
Comment 5 Daniel Friesen 2008-06-13 23:28:32 UTC
JS Hacks? What are you talking about. Last time I checked the methods for adding buttons to the toolbar were clean JS functions.

There is nothing wrong with that. The buttons use JS to add things into the text box, so there's nothing wrong with using JS to add new buttons. MW makes JS readily available for the site, and also for individual users. Making use of things like [[MediaWiki:EditButtons]] would only help sites, it doesn't help an individual user at all.
Comment 6 Anders Einar Hilden 2008-06-13 23:52:58 UTC
The problem is modifying button that at defined in includes/EditPage.php. If i am not very wrong, that is where the singature-button-js is located. 
Comment 7 Stig Meireles Johansen 2008-06-17 23:40:06 UTC
I have made this little hack to do the requested modifications (the "nasty" js-hack):

Given that the editbuttons are localized, I think it would be somewhat difficult to do a entirely dynamic configuration of the buttons, but it shouldn't be too difficult to make the image, open, close and key-parameters also a part of the Message-files (ie. localized). This way it would be possible to edit the contents in the MediaWiki-namespace and get rid of awkward js-hacks in the global js-files (as now introduced in nowiki).
Comment 8 Danny B. 2008-07-20 10:03:32 UTC
*** Bug 14808 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.