Last modified: 2012-12-16 17:43:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16444, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14444 - Ajax search feature does not work in modern skin
Ajax search feature does not work in modern skin
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Brion Vibber
Depends on:
Blocks: ajax
  Show dependency treegraph
Reported: 2008-06-06 16:23 UTC by Edward Rudd
Modified: 2012-12-16 17:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Edward Rudd 2008-06-06 16:23:32 UTC
The ajax search feature works fine using the monobook skin, but it fails to function properly using the modern skin.

The cause is the ajaxsearch.js code expects to find a div with the id of "content" and in modern the div is named "mw_content" instead.

This can be fixed either by one of the following
1. changing the modern theme to use the same ID as the rest of the themes..
2. change the rest of the themes to use mw_content id and update the ajaxsearch.js to use that ID as well
3. update ajax search to check BOTH ids.  
   body = document.getElementById("content") || document.getElementById("mw_content");
Comment 1 Brion Vibber 2008-06-06 16:33:18 UTC
The old ajax search is obsoleted by the new ajax suggest search; I'm probably going to remove it today, so this bug'll be obsolete. :)
Comment 2 Siebrand Mazeland 2008-08-16 22:08:56 UTC
Brion, has this been done? If so, please close.
Comment 3 Brion Vibber 2008-08-20 18:13:21 UTC
Now that 1.13 release is past, I've gone ahead and removed the old AJAX search in r39717.

The new suggestion search works fine in Modern, so mission accomplished. :)

Note You need to log in before you can comment on or make changes to this bug.