Last modified: 2011-07-07 13:52:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15620, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 13620 - #iferror should catch imagemap errors
#iferror should catch imagemap errors
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
ParserFunctions (Other open bugs)
unspecified
All All
: Low normal with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/wiki/Benutzer...
: patch
Depends on:
Blocks: UNIQ
  Show dependency treegraph
 
Reported: 2008-04-05 20:42 UTC by René Kijewski
Modified: 2011-07-07 13:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (375 bytes, patch)
2008-04-07 15:41 UTC, René Kijewski
Details
Strip the UNIQ markers (660 bytes, patch)
2009-03-10 14:15 UTC, Raimond Spekking
Details

Description René Kijewski 2008-04-05 20:42:34 UTC
If you enter a wrong syntax, imagemaps display: <p class="error">...</p>.

If it would be <p><span class="error">...</span></p>, errors could be caught by #iferror.
Comment 1 René Kijewski 2008-04-07 15:41:44 UTC
Created attachment 4790 [details]
Proposed patch

patch against rev 31730
Comment 2 Raimond Spekking 2008-04-09 19:50:19 UTC
Based on the discussion on http://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=44710904#K.C3.B6nntest_du_einen_Bugreport_f.C3.BCr_mich_umsetzen.3F 

#iferror function from ParserFunctions.php modified with r33047 to catch more error messages.
Comment 3 Finn Pauls 2008-04-10 12:56:30 UTC
The patch didn't solve the problem obviously.
Comment 4 Brion Vibber 2008-04-11 18:50:24 UTC
Please provide a URL demonstrating the error.
Comment 5 Finn Pauls 2008-04-12 00:27:35 UTC
(In reply to comment #4)
> Please provide a URL demonstrating the error.
> 
http://de.wikipedia.org/wiki/Benutzer:Finn-Pauls/Bug
Comment 6 Raimond Spekking 2009-03-10 14:15:12 UTC
Created attachment 5907 [details]
Strip the UNIQ markers

After discussion at http://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=57698683#Mal_wieder_ein_Wunsch_zu_einem_Bug see the attached patch which strips the UNIQ markers.
Comment 7 René Kijewski 2009-04-09 06:31:12 UTC
Comment on attachment 5907 [details]
Strip the UNIQ markers

I withdraw the patch. It may mess around with <nowiki> tags.
It would be possible to parse the XML tree of $unstripped and look for the class error with xpath. But I guess this would be somewhat expensive.
Comment 8 p858snake 2011-04-30 00:10:02 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 9 Mark A. Hershberger 2011-07-07 13:52:28 UTC
The demo page has been deleted and there isn't enough information on the bug to duplicate this.  If you reopen, please provide a demonstration of the problem.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links