Last modified: 2008-01-03 21:14:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14493, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12493 - MAX_FILE_SIZE shouldn't be hard coded in SpecialImport.php
MAX_FILE_SIZE shouldn't be hard coded in SpecialImport.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-03 17:36 UTC by Huji
Modified: 2008-01-03 21:14 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Huji 2008-01-03 17:36:55 UTC
Currently, MAX_FILE_SIZE is hardcoded in SpecialImport.php, which should be changed so that it could be set thorugh LocalSettings.php
Comment 1 Brion Vibber 2008-01-03 20:55:14 UTC
I've removed the limit in r29234; I can't really see any reason to have the extra limit. Not really sure how it snuck in, but it's been there since 2005. :)
Comment 2 Huji 2008-01-03 21:14:06 UTC
I think it was there because PHP really has two ways to know the maximum upload size: through php.ini settings and by MAX_FILE_SIZE paramter sent togeather with the file (http://www.php.net/manual/en/features.file-upload.errors.php). However, I agree with you that it is useless and should have been removed already.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links