Last modified: 2010-05-15 15:59:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14441, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12441 - generateSitemap.php --fspath: add detalis
generateSitemap.php --fspath: add detalis
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
1.11.x
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-28 12:53 UTC by Dan Jacobson
Modified: 2010-05-15 15:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2007-12-28 12:53:05 UTC
In maintenance/generateSitemap.php at

  --fspath=<path> The file system path to save to, e.g /tmp/sitemap/

please add

  Note: "/tmp/sitemap/" is a directory that must be made before the
  command is run. "/tmp/sitemap" is on the other hand a filename
  prefix which will be prepended to the names of the files created.
Comment 1 Daniel Friesen 2008-04-04 02:36:10 UTC
/tmp/sitemap as a prefix isn't something intended of the system. It appears that the real issue here is that the path requires a trailing /, unlike any other setting in MediaWiki. Because it requires that of the user instead of autocreating it, people mistakenly forget the / and end up creating a poor, as the bug reporter calls it 'prefix' to the filename.

I suggest some automatic code to make sure a / is used after the directory rather than calling part of the path a 'prefix'. If you want a real prefix, it should be done with a --prefix parameter, not the fspath. But that really isn't needed with the fact that wfWikiId() is used to create the filename.
Comment 2 Antoine "hashar" Musso (WMF) 2008-07-19 12:54:14 UTC
Fixed with r37846

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links