Last modified: 2011-04-14 15:11:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14359, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12359 - Deletion summary lengths problems
Deletion summary lengths problems
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
1.12.x
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://es.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks: 4714
  Show dependency treegraph
 
Reported: 2007-12-19 22:31 UTC by Platonides
Modified: 2011-04-14 15:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Platonides 2007-12-19 22:31:57 UTC
These are in fact two different bugs on the same code:
a) Deletion summary was prefilled with up to 150 characters from the page content, leaving space for the sysop to add his reason. r27170 changed it to the maximun available (allowed by the language), eating that content. Rationale was "In the deletion default reasons, calculate how much text to get from the article text, rather than getting 150 characters (which may be too much)". I don't know why max(150, $maxLength) wasn't used. (Regression was complained onm ML).

b) With r27832 (bug 9633) the calculated length isn't accurate any more. The delete reason from the list is prepended and mysql trims the reason field (see URL). Either change the <input maxlength to 255 - max(strlen(deletereasons)) or perform some black magic with javascript when changing the combo value (hard to get right).
Comment 1 Splarka 2009-05-07 06:22:46 UTC
> b) With r27832 (bug 9633) the calculated length isn't accurate any more.

Selecting from the dropdown of reasons should probably override (and if JS is avaiable, blank) the 'reason' field.
Comment 2 Mike.lifeguard 2009-05-09 00:47:42 UTC
(In reply to comment #1)
> > b) With r27832 (bug 9633) the calculated length isn't accurate any more.
> 
> Selecting from the dropdown of reasons should probably override (and if JS is
> avaiable, blank) the 'reason' field.
> 

No, using both is a common use case.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links