Last modified: 2008-04-29 20:57:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12249 - subpage parsing crashes somewhere
subpage parsing crashes somewhere
Status: RESOLVED DUPLICATE of bug 13796
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Normal minor with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-12-08 23:30 UTC by italvet
Modified: 2008-04-29 20:57 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description italvet 2007-12-08 23:30:06 UTC
with titles with slashes in it like

the software don't generate the "subpages" section

And for this

where the software generate a link to

but not to

because don't exist ?

I don't know what the bug exactly is but i just want to notify of these problems.
Comment 1 Dashiva 2007-12-08 23:40:02 UTC
Generally on subpages: They are listed from the uppermost parent (e.g. "Programmation_JavaScript") and further until a non-existent subpage is encountered. Then it stops. So for the first case, the topmost parent does not exist, thus no parent links are generated. For the second case, only the topmost exists, so only that is linked.

And at and subpages, I get a completely messed up header:

null<a href="wiki/Programmation_JavaScript" title="Programmation JavaScript>Programmation JavaScript Références/Objets/RegExp

followed by a tiny "Programmation JavaScript/Références/Objets/RegExp"
Comment 2 italvet 2007-12-08 23:52:16 UTC
ah, what is your browser please ? the setupTitle() function here who "mess" the header is supposed to work with IE7, Opera 9.24 and fx2.0
Comment 3 Dashiva 2007-12-09 00:51:56 UTC
Using JS to change the title? Eh... that function is such a mess.

This line: titre.innerHTML = null;
Should be: titre.innerHTML = "";
(innerHTML is a string, string-form of null is "null", setting .innerHTML = null is not reliable)

This line: + "\>"
Should be: + "\">"
(Otherwise the title attribute never closes)
Comment 4 italvet 2007-12-09 02:07:47 UTC
is your javascript up to date ? i'm sure that i've fixed these bugs yesterday

for our problem i think that there is 3 ways to display the subpages of

1 : like now. if a subpage is missing, then stop. not so bad

2 : [[Programmation_JavaScript]] > Références > [[Objets]] > [[RegExp]] (Références in grey with no link)

3 : [[Programmation_JavaScript]] > [Références action=edit] > [[Objets]] > [[RegExp]] (Références in red link)

i'm not sure what is best


for the best behaviour is undoubtly to generate a subpages section. maybe i should split this bug ?
Comment 5 Dashiva 2007-12-09 02:39:11 UTC
Maybe it was serving up an older cached version to anon users, as I hadn't even been to the site until this bug was filed today. Well, a forced regen fixed it.

Back on topic. The HTML gets the entire subtitle string from Monobook, which uses the subtitle key from SkinTemplate. This in turn uses a string from subPageSubtitle in Skin. This method loops over each subpage and breaks when it finds one that doesn't exist.

So there are two main options. You can aim for a change in Skin.php to remove the break for non-existent subpages; might be difficult to get into the main line. Or you can create the full link set using javascript, based on the full title; this is rather hackish, but not that much worse than what you already have.

Comment 6 italvet 2008-04-27 18:16:39 UTC
the problem seems to no more occur, i guess because of this patch

One could close this bug so ?
Comment 7 Brion Vibber 2008-04-29 20:57:14 UTC

*** This bug has been marked as a duplicate of bug 13796 ***

Note You need to log in before you can comment on or make changes to this bug.