Last modified: 2014-10-01 19:43:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13700, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 11700 - Edit tab on cascade protected pages
Edit tab on cascade protected pages
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.21.x
All All
: Lowest normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 14104 17036 17373 25539 58452 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-18 16:40 UTC by Nick
Modified: 2014-10-01 19:43 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nick 2007-10-18 16:40:58 UTC
On pages automatically protected due to cascading protection, the "edit" tab does not change to "view source". The page only shows it is protected when the user clicks the tab and sees the "view source" screen. This has been tested on Wikipedia from a template cascade protected from the main page, as well as on a test wiki on my own web server.
Comment 1 Rob Church 2007-10-18 17:38:20 UTC
This is intentional; checking cascade protection status is quite an expensive operation, so we avoid doing it when it's not needed, i.e. on page views - when the edit operation commences, we do a full check.

Not sure whether use of object caching would be considered effective enough to make this happen for Wikimedia sites; per default, it'd be too expensive for quite a few sites.
Comment 2 Andrew Garrett 2007-12-05 11:21:44 UTC
This is deliberate, and is done for performance reasons.
Comment 3 MZMcBride 2009-01-16 02:13:00 UTC
*** Bug 17036 has been marked as a duplicate of this bug. ***
Comment 4 P.Copp 2009-02-05 18:43:25 UTC
*** Bug 17373 has been marked as a duplicate of this bug. ***
Comment 5 db [inactive,noenotif] 2010-10-16 20:13:14 UTC
*** Bug 25539 has been marked as a duplicate of this bug. ***
Comment 6 db [inactive,noenotif] 2011-04-20 19:17:28 UTC
*** Bug 14104 has been marked as a duplicate of this bug. ***
Comment 7 Paine Ellsworth 2012-11-17 14:12:14 UTC
There is something about this bug that was not mentioned.  If not changing the "Edit" to "View source" were the only consideration, then I can see why this resulted in WONTFIX.  Another result of this bug is that the protected pages become categorized incorrectly.  Here is an example:  

http://en.wikipedia.org/w/index.php?title=Template:CN&redirect=no 

That template shortcut should have been categorized into the "Protected redirects" category.  Instead it was categorized into the "Wikipedia pages with incorrect protection templates" category.  If many pages have been thusly miscategorized, then the need for a solution cannot be ignored under any circumstances.
Comment 8 Paine Ellsworth 2012-11-24 23:01:07 UTC
I have a question:  The following is printed in the pink warning box that tells editors that the page is protected *after* they click on "Edit"... 

"This page is currently protected from editing because it is transcluded in the following page, which is protected with the "cascading" option:

* Wikipedia:Cascade-protected items 
  (http://en.wikipedia.org/wiki/Wikipedia:Cascade-protected_items) 

To suggest an edit to this page, submit an edit request on the talk page.

That warning accompanies the "CN" REDIRECT to the "Citation needed" template. 

My question is... what about the "Cn" REDIRECT? (Note the lowercase "n")  That redirect is also transcluded to the WP:Cascade-protected items page, but when you check the Cn REDIRECT, you find the "Source" instead of the "Edit" tab, and that REDIRECT is placed into the "Protected redirects" category, i.e., the CORRECT category.  So why does the Cn REDIRECT work correctly, but the CN REDIRECT does not?
Comment 9 Paine Ellsworth 2012-12-04 02:29:08 UTC
> My question is... what about the "Cn" REDIRECT? (Note the lowercase "n")  That
> redirect is also transcluded to the WP:Cascade-protected items page, but when
> you check the Cn REDIRECT, you find the "Source" instead of the "Edit" tab, and
> that REDIRECT is placed into the "Protected redirects" category, i.e., the
> CORRECT category.  So why does the Cn REDIRECT work correctly, but the CN
> REDIRECT does not?

Anomie explained to me how this happens.  I still wonder, though, how this can be fixed, so that 1) the "Source" takes the place of the "Edit" tab, and 2) the redirect gets placed into the correct category, "Protected redirects", instead of being placed into a category that indicates that the redirect has been miscategorized?
Comment 10 Paine Ellsworth 2013-03-12 17:13:12 UTC
So, initially I was told that this had to be fixed at the "software level": 

http://en.wikipedia.org/wiki/Template_talk:Citation_needed#Protected_shortcut_redirects

Is the previous "WONTFIX" actually a wontfix, a cantfix or what?  Is the only solution for a WP admin to go in and "doubly" protect a page that is already cascade protected? The following redirect: 

http://en.wikipedia.org/w/index.php?title=Template:CN&redirect=no

... is still miscategorized and still shows "Edit" where it should show "View source".  Is there or is there not a solution to this problem?
Comment 11 Paine Ellsworth 2013-03-24 01:35:26 UTC
I see where the CN shortcut no longer shows "Edit" where "View source" should be, and it is now correctly categorized.  Is this because this bug has been fixed? or because someone went ahead and doubly protected the shortcut?
Comment 12 Paine Ellsworth 2013-03-24 04:38:39 UTC
(In reply to comment #11)
> I see where the CN shortcut no longer shows "Edit" where "View source" should
> be, and it is now correctly categorized.  Is this because this bug has been
> fixed? or because someone went ahead and doubly protected the shortcut?

Never mind, as I see it's been doubly protected, both manually and by cascade.
Comment 13 Bartosz Dziewoński 2013-12-13 18:34:26 UTC
*** Bug 58452 has been marked as a duplicate of this bug. ***
Comment 14 Rezonansowy 2013-12-13 19:15:20 UTC
See "edit" tab on https://commons.wikimedia.org/wiki/Template:Delete/layout

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links