Last modified: 2007-12-01 15:36:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11113 - checkLanguage.php does not find unexisting messages
checkLanguage.php does not find unexisting messages
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2007-08-29 15:52 UTC by Lejonel
Modified: 2007-12-01 15:36 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

set default lang code before it is used (1.14 KB, patch)
2007-09-03 15:25 UTC, Lejonel

Description Lejonel 2007-08-29 15:52:06 UTC
checkLanguage.php in the /maintenance/language directory does no longer list translated messages that do not exist in the English message file. That check was useful so it should be restored.
Comment 1 Raimond Spekking 2007-08-30 07:19:19 UTC
Works for me in r25301.
Comment 2 Lejonel 2007-08-30 16:23:51 UTC
After some testing I see that the check is performed when a language is specified by the --lang parameter, but not when using the default language from the wiki installation.
Comment 3 Raimond Spekking 2007-08-30 16:25:31 UTC
Ah ok, I never tried/used this before. Sorry for closing.
Comment 4 Lejonel 2007-09-03 15:25:17 UTC
Created attachment 4072 [details]
set default lang code before it is used

The problem seems to be that the default language code is not set until after the code is used to get the messages.
This patch for moves the code that sets the default language and default checks to the beginning of the checkLanguage function, so that the language code is set when it is used to get messages.
Comment 5 Lejonel 2007-12-01 15:36:06 UTC
Now this works again. I think it was revision 26721 by Nikerabbit that fixed the problem.

Note You need to log in before you can comment on or make changes to this bug.