Last modified: 2007-08-06 03:30:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12793, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10793 - Mark as patrolled link doesn't show up when using Next diff/Previous diff
Mark as patrolled link doesn't show up when using Next diff/Previous diff
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.11.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-08-03 20:08 UTC by Roan Kattouw
Modified: 2007-08-06 03:30 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2007-08-03 20:08:12 UTC
Steps to reproduce: (requires you to be sysop)
1. Find two consecutive non-patrolled edits (you can also make them yourself by logging out first)
2. Click on the diff link for the first edit (in recentchanges).
3. A [Mark as patrolled] link appears.
4. Click Next diff->
5. There is no [Mark as patrolled] link.
6. Click <-Previous diff
7. The [Mark as patrolled] link you saw in step 3 has disappeared.

More precisely, the problem here is that the rcid isn't passed when using the next/prev links. Wouldn't it be possible to just look up the revision ID in the recentchanges table rather than using the rcid? This would make [Mark as patrolled] links for diffs from the History or for combined diffs possible as well.
Comment 1 Rob Church 2007-08-06 03:30:11 UTC
Fixed in r24607; now showing patrol links on all eligible diff pages, where appropriate.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links