Last modified: 2007-07-17 17:45:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12594, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10594 - Inclusion of MediaWiki:GeSHi.css uses invalid CSS
Inclusion of MediaWiki:GeSHi.css uses invalid CSS
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-15 20:14 UTC by Aryeh Gregor (not reading bugmail, please e-mail directly)
Modified: 2007-07-17 17:45 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-15 20:14:06 UTC
@import statements must not occur except at the beginning of a stylesheet for some reason: "CSS 2.1 user agents must ignore any '@import' rule that occurs inside a block or after any valid statement other than an @charset or an @import rule." (http://www.w3.org/TR/CSS21/syndata.html#at-rules)  The same is true in CSS3 (http://www.w3.org/TR/css3-syntax/#import).  Firefox at least seems to correctly ignore the invalid declaration: "Unrecognized at-rule or error parsing at-rule '@import'."  So the customizations in MediaWiki:Geshi.css do nothing.

Easily fixable by breaking the import off into its own style tag, or using <link>, so you wonder why they bothered making the distinction.  Or just by writing our own stylesheet and not using GeSHi's default angry fruit salad (which also forces Courier (New) for monospace instead of relying on browser default, blah).
Comment 1 Brion Vibber 2007-07-17 17:45:15 UTC
Fixed in r24208

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links