Last modified: 2007-06-28 16:46:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12397, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 10397 - AJAX watch error fallback doesn't work
AJAX watch error fallback doesn't work
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.11.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-06-28 14:33 UTC by Brion Vibber
Modified: 2007-06-28 16:46 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2007-06-28 14:33:29 UTC 
Found while reviewing patch for bug 10387, triggered via bug 10396.

The AJAX watch/unwatch code is supposed to fallback to the traditional watch/unwatch link if the AJAX request doesn't work.

Unfortunately that fallback isn't actually working. This is usually hidden as failures are unlikely if the AJAX setup code determines that AJAX won't work, but a problem that prevents the request from working on the server end will leave it in failure mode.

The button changes to "watching..." but never changes back.

Error condition should be better detected, and the fallback mode used.
Comment 1 Brion Vibber 2007-06-28 15:05:54 UTC 
Fixed in r23506.

It was only doing the fallback if the AJAX server code returned an <err#> response, which doesn't happen if things are fundamentally broken. :)

Now runs fallback for any unrecognized response.
Comment 2 AlexSm 2007-06-28 16:46:57 UTC 
Comment: the script could also do fallback if there is no response at all (using already existing setTimeout function).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links