Last modified: 2010-05-15 15:37:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 996 - $wgWhitelist* variables no longer have any apparent effect.
$wgWhitelist* variables no longer have any apparent effect.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.5.x
All All
: High normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
: 1043 (view as bug list)
Depends on:
Blocks: 767 1002 2422
  Show dependency treegraph
 
Reported: 2004-12-04 05:13 UTC by Stephen Matta
Modified: 2010-05-15 15:37 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to obsolete wgWhitelistEdit (4.08 KB, patch)
2005-06-17 08:20 UTC, Rob Lanphier (RobLa)
Details
Patch to obsolete wgWhitelistEdit (4.29 KB, patch)
2005-06-25 05:35 UTC, Rob Lanphier (RobLa)
Details

Description Stephen Matta 2004-12-04 05:13:38 UTC
I moved my old wiki directory and created a new directory to test the 1.4 Beta.
 I used an existing database.  I copied these three lines from my old
LocalSettings.php directory and into the new one created by the install script:

$wgWhitelistAccount = array ( 'user' => 0, 'sysop' => 1, 'developer' => 1 );
$wgWhitelistEdit = true;
$wgWhitelistRead = array ("Special:Userlogin");

The old version of the wiki prevents any non-logged-in user from doing anything
but logging in. The new version does no such thing.
Comment 1 Antoine "hashar" Musso (WMF) 2004-12-04 20:09:48 UTC
this is due to the "user group level" patch.
Comment 2 Brion Vibber 2004-12-09 00:20:50 UTC
Comment from dupe bug 1043:

Following the steps outlined in http://meta.wikimedia.org/wiki/Preventing_Access
do not work as expected.

From what I can tell, this is due to the default settings of the groupRights
hash located in includes/User.php, in the isAllowed function, line 625. Changing
the value of 'read' from '*' to 'user' seems to fix the problem.
Comment 3 Brion Vibber 2004-12-09 00:20:52 UTC
*** Bug 1043 has been marked as a duplicate of this bug. ***
Comment 4 Brion Vibber 2004-12-10 03:59:27 UTC
Fixed in 1.4 CVS (for beta2).

This will still need to be dealt with in 1.5, with the new user levels stuff.
Comment 5 Anders Wegge Jakobsen 2005-04-23 20:39:35 UTC
(In reply to comment #4)
> Fixed in 1.4 CVS (for beta2).
> 
> This will still need to be dealt with in 1.5, with the new user levels stuff.

The same could be achieved in 1.5 by removing "edit" from the groups Anonymous
and Logged in, so it should just be a metter of documenting this?
Comment 6 Brion Vibber 2005-06-16 06:59:33 UTC
$wgWhitelistAccount has now been replaced by the createaccount permission in $wgGroupPermissions.

$wgWhitelistEdit and $wgWhitelistRead may still need to be tweaked or removed in deference to 
group config.
Comment 7 Rob Lanphier (RobLa) 2005-06-17 05:52:47 UTC
I did some testing on this.  wgWhitelistRead works the same way in MediaWiki/CVS
as it does in MediaWiki/1.4.5, and I think it still makes sense in the brave new
world of group config.  wgWhitelistEdit also still works the same....though it
feels a little peculiar given that one would expect an 'edit' permission.  I'll
write up a patch to replace wgWhitelistEdit with isAllowed('edit')

In order for wgWhitelistRead to work properly, you must override the default
permissions by overriding the permissions for group '*'.  '*' is the list of
permissions everyone has, even anonymous users.  The default value for this is
array('createaccount', 'read').  To override, add this line to your
LocalSettings.php:
$wgGroupPermissions['*'] = array('createaccount');

Comment 8 Rob Lanphier (RobLa) 2005-06-17 08:20:01 UTC
Created attachment 615 [details]
Patch to obsolete wgWhitelistEdit

This removes wgWhitelistEdit, replacing it with wgGroupPermissions('edit')
permission to add on per-group basis
Comment 9 Rob Lanphier (RobLa) 2005-06-25 05:35:58 UTC
Created attachment 645 [details]
Patch to obsolete wgWhitelistEdit

Updating patch to remove conflict from latest CVS (previous patch still used
old-style wgGroupPermissions declarations)
Comment 10 Brion Vibber 2005-06-25 06:27:05 UTC
Applied patch.

$wgWhitelistEdit is now obsolete, and UPGRADE explains what needs to be done to convert 
$wgWhitelistAccount, $wgWhitelistEdit, and $wgWhitelistRead settings to new system.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links