Last modified: 2007-06-13 20:08:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9948 - Diff no longer wraps text in Mozilla 1.1 - truncates lines in both compared versions
Diff no longer wraps text in Mozilla 1.1 - truncates lines in both compared v...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
Macintosh Linux
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-18 01:57 UTC by Marek W. Lugowski
Modified: 2007-06-13 20:08 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of Mozilla 1.1 showing the bug. Note lines at the bottom of diff -- they are truncated. (135.86 KB, image/png)
2007-05-18 01:57 UTC, Marek W. Lugowski
Details
A possible JavaScript-based workaround (2.67 KB, patch)
2007-05-24 21:04 UTC, Brion Vibber
Details

Description Marek W. Lugowski 2007-05-18 01:57:53 UTC
Created attachment 3650 [details]
screenshot of Mozilla 1.1 showing the bug.  Note lines at the bottom of diff -- they are truncated.

As of today, diff no longer wraps lines in Mozilla 1.1 browser.  It shows only the beginning of lines, browser window size-dependent.  This makes diff unususable in most instances.  Demonstrated en and pl Wikipedia, Commons.

Does not happen in Firefox 1.6a or Opera 9.20 on the same platform (linux/ppc).  Does not happen in SeaMonkey 1.1.1 on Windows XP SP2.

Bug did not happen as of yesterday (16 May 2007).
Comment 1 Brion Vibber 2007-05-18 15:35:56 UTC
Seems to be a bug with overflow: auto in ancient versions of Gecko; confirmed in 1.1 on Mac OS X.

It seems to work fine in Mozilla 1.2.1 (copyright 1998-2002), so you might try upgrading to a slightly more recent Mozilla release.
Comment 2 Brion Vibber 2007-05-18 15:37:04 UTC
(Note it's showing scrollbars in 1.1/Mac, but they're very small and vertical.)
Comment 3 Brion Vibber 2007-05-24 21:04:03 UTC
Created attachment 3673 [details]
A possible JavaScript-based workaround

I'm not entirely happy with this, but it seems to do the job as long as JavaScript is available...

This does a quickie JavaScript hack to check specifically for Gecko older than the version reported by Mozilla 1.2.1, and override the 'overflow: auto' style back to 'overflow: visible'. The result is that very long diff lines will spill out, but without disrupting the page layout. Sub-ideal but much better than the current behavior.

Downside is that it won't trigger without JS.

I'm leery of server-side User-Agent checks for something like this; I'd prefer to find a nice friendly CSS layout that doesn't break the old Mozillas, of course. :)

One other possibility is to change the diff.css definitions to use overflow-x and overflow-y instead of overflow; this is supported in Mozilla 1.9 / Firefox 1.5 and later, where the overflow properties actually work properly... but not by Mozilla 1.2 through 1.7, Firefox 1.0, or Opera. So it would provide sub-ideal output on many more not-quite-current browsers and some current ones.
Comment 4 Brion Vibber 2007-05-24 21:04:52 UTC
(should say Mozilla 1.8, not 1.9, above.)
Comment 5 Marek W. Lugowski 2007-06-08 02:57:00 UTC
What's the status of incorporating the JavaScript remedy proposed above in production code?  It's not there as of WikiMedia 1.11alpha (r22718).  The fix does work for me on the affected machine where the bug was noticed and for Mozilla 1.1beta on Mac Os X.

Has it already gone in and possibly got overwritten, or is it still in the queue?  Or are the developers considering a different fix?
Comment 6 Brion Vibber 2007-06-13 20:08:32 UTC
Applied with fixes in r22970

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links