Last modified: 2010-05-15 15:51:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11882, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9882 - update.php for MW 1.10.0 doesn't completely update the DB
update.php for MW 1.10.0 doesn't completely update the DB
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.10.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-11 21:29 UTC by Voyagerfan5761 / dgw
Modified: 2010-05-15 15:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Voyagerfan5761 / dgw 2007-05-11 21:29:48 UTC
The new `page_restrictions` table in MediaWiki 1.10.0 brings a lot of new
features, but the update.php script included with the new version doesn't
completely update the page restrictions. Moving the restrictions from the `page`
table to `page_restrictions` makes them unlistable in Special:Protectedpages
unless all the migrated entries have the NULL default value in the pr_expiry
column changed to "infinity" or some other expiry date. The update script should
do this automatically, or the column should be set to default to "infinity"
instead of NULL.
Comment 1 Aaron Schulz 2007-05-11 21:32:29 UTC
The updater.inc script does use 'infinity' as the pr_expiry value, as does
updateRestrictions.php
Comment 2 Aaron Schulz 2007-05-11 21:35:12 UTC
Ok, /trunk does, I see 1.10 is still behind there.
Comment 3 Voyagerfan5761 / dgw 2007-05-11 22:00:58 UTC
I actually ran both scripts from the Windows command line (cmd.exe), using the
commands 'php update.php' and 'php updateRestrictions.php' in the
C:\apache\htdocs\w\maintenance directory, where MediaWiki maintenance scripts
are stored. I ended up changing the few protected rows manually with phpMyAdmin,
but I have a small wiki with less than 20 protected pages (currently), and it's
only on my computer. Still, for larger wikis, this could be a problem. Will this
be changed in the next release (1.10.1)?
Comment 4 Brion Vibber 2007-05-14 15:01:43 UTC
The default NULL value should be perfectly fine here.

Why, exactly, would it be a problem?
Comment 5 Voyagerfan5761 / dgw 2007-05-16 23:54:07 UTC
(In reply to comment #4)
> The default NULL value should be perfectly fine here.
> 
> Why, exactly, would it be a problem?

I tried using the default after upgrading and none of the protected pages showed up in the list. It was old entries that were messed up; new protections made in MW 1.10.0 were just fine.
Comment 6 Aaron Schulz 2007-09-30 20:57:55 UTC
The update script was changed. Also, the GROUP BY clause was removed. Both would solve this problem.
Comment 7 Aaron Schulz 2007-09-30 21:00:57 UTC
*** Bug 10700 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links