Last modified: 2011-07-07 19:48:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9868 - Merge rtl.css into main.css
Merge rtl.css into main.css
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2007-05-10 16:56 UTC by Robert Leverington
Modified: 2011-07-07 19:48 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Basic patch for monobook (3.87 KB, patch)
2007-05-10 19:09 UTC, Robert Leverington
Details

Description Robert Leverington 2007-05-10 16:56:59 UTC
rtl.css should be merged with main.css for the MonoBook skin.
Comment 1 Robert Leverington 2007-05-10 16:57:32 UTC
My bad, this is for all skins.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-10 17:20:21 UTC
Specifically, RTL <body>s or other areas should have a class like
.mw-rtl/.mw-ltr, or whatever.  We can also support [dir=rtl]/[dir=ltr] as being
equivalent, for those browsers that support them.
Comment 3 Robert Leverington 2007-05-10 17:43:11 UTC
Working on this.
Comment 4 Robert Leverington 2007-05-10 19:09:21 UTC
Created attachment 3617 [details]
Basic patch for monobook

This moves all of the rtl code for monobook into main.css - this works in
Firefox and Opera (with exactly the same bugs as before moving the code) but
not IE6. This code could probably be used if you can figure out where the
rtl.css is added to monobook so an IE if statement can be wrapped around it -
otherwise don't use this patch.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-12-18 03:29:44 UTC
See also bug 6100.  I'm preparing a rather sweeping patch there that aims to fix this too.
Comment 6 Danny B. 2008-02-12 21:29:56 UTC
RTL override stylesheet SHOULD NOT be merged with any LTR stylesheet at all.

Both environments should not be mixed because of clear distinction and why would the LTR user have to download a bunch of useless stuff -> increases traffic too.
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-02-12 21:32:47 UTC
Keeping them separate means that LTR-biased developers add stuff to the LTR stylesheet without thinking about the RTL stylesheet.  Combining them reduces code duplication, and reduces the number of page requests for RTL wikis.  The amount of extra material that needs to be added to the main stylesheets to accommodate RTL, on the other hand, is small.
Comment 8 Siebrand Mazeland 2011-03-20 19:45:48 UTC
Any progress?
Comment 9 Roan Kattouw 2011-03-20 20:07:44 UTC
(In reply to comment #8)
> Any progress?
CSS loaded through ResourceLoader is automatically flipped for RTL. Existing rtl.css files need to be audited for any RTL-specific hacks that we need, and those need to be moved to the main CSS files. CC Trevor and Timo for that reason.
Comment 10 p858snake 2011-04-30 00:09:36 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 11 DieBuche 2011-07-07 16:40:27 UTC
rtl was merged in r74966
Comment 12 Robin Pepermans (SPQRobin) 2011-07-07 16:54:57 UTC
Shouldn't we delete the rtl.css file as it is no longer used?
Comment 13 DieBuche 2011-07-07 19:48:00 UTC
Right. Done in r91672

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links