Last modified: 2010-05-15 15:28:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T2975, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 975 - UserMailer() function: mail with new password has superfluous CR in header
UserMailer() function: mail with new password has superfluous CR in header
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.3.x
PC Linux
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-12-02 05:47 UTC by Ernst Schwab
Modified: 2010-05-15 15:28 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ernst Schwab 2004-12-02 05:47:18 UTC
The email sent by MediaWiki containing a new password has some additional 
carriage return characters in some header lines. Due to this, some email 
clients (e.g. Outlook Express...) display part of the mail header in the body 
of the mail, resulting in a missing 'From:' and missing charset declaration.

The problem can be fixed by removing four '\r' characters in 
includes/UserMailer.php, function userMailer(), lines 46ff:

New version:
		$headers =
			"MIME-Version: 1.0\n" .
			"Content-type: text/plain; charset={$wgOutputEncoding}
\n" .
			"Content-transfer-encoding: 8bit\n" .
			"From: {$from}\n" .
			"X-Mailer: MediaWiki interuser e-mailer";

Existing version (V1.3.7/1.3.8):
		$headers =
			"MIME-Version: 1.0\r\n" .
			"Content-type: text/plain; charset={$wgOutputEncoding}
\r\n" .
			"Content-transfer-encoding: 8bit\r\n" .
			"From: {$from}\r\n" .
			"X-Mailer: MediaWiki interuser e-mailer";

The change was tested on a Debian sarge system and fixed the problem.
Comment 1 Hendrik Brummermann 2005-01-08 12:09:32 UTC
Hashar fixed this in 1.4.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links