Last modified: 2007-10-04 21:44:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9718 - Undo r11305 changes to main.css
Undo r11305 changes to main.css
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All other
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/skins-1.5/mon...
: easy, patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-27 00:29 UTC by Splarka
Modified: 2007-10-04 21:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Removes the offending css items (689 bytes, patch)
2007-10-04 21:36 UTC, Robert Leverington
Details

Description Splarka 2007-04-27 00:29:47 UTC
r11305 introduced some new CSS in an apparent redesign of the navigation
portlet, which uses the id definition #p-navigation in main.css. However, due to
the advent of MediaWiki:Sidebar, this only affects the top portlet (and only if
the first line is "* Navigation" (and possibly only in English?), as new sidebar
portlets are given an ID to match the portlet heading.

Part of the css defines "#p-navigation a { display: block; }" which gives the
top sidebar portlet links a slightly different spacing on some browsers (example
http://test.wikipedia.org/wiki/Image:Portletfunky.gif ).

It also seems, that #p-navigation li are no longer ever given class="active", so
probably the whole section in main.css under "** the navigation portlet" should
be removed as unneeded.
Comment 1 Robert Leverington 2007-10-04 21:36:26 UTC
Created attachment 4215 [details]
Removes the offending css items

This patch removes the block of #p-navigation css items, it doesn't appear to make the page look different and is broken regardless due to its implementation. If this really does change things for the better (which I cannot see and has never caused any complaints) there is no way to correctly implement it without changes to the classes in the skin as there are many .portal 's.
Comment 2 Daniel Cannon (AmiDaniel) 2007-10-04 21:43:22 UTC
Committed as r26419.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links