Last modified: 2007-04-24 19:09:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9678 - Record client IP in cuc_xff_hex
Record client IP in cuc_xff_hex
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Aaron Schulz
Depends on:
  Show dependency treegraph
Reported: 2007-04-24 15:11 UTC by Aaron Schulz
Modified: 2007-04-24 19:09 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch for ProxyTools (1.52 KB, patch)
2007-04-24 15:19 UTC, Aaron Schulz
Trim, anchor (1.52 KB, patch)
2007-04-24 15:30 UTC, Aaron Schulz
Test if each server is trusted (2.09 KB, patch)
2007-04-24 15:58 UTC, Aaron Schulz
Remove test line, ignore NULL $addresses (1.96 KB, patch)
2007-04-24 16:01 UTC, Aaron Schulz
Move to checkuser.php (2.20 KB, patch)
2007-04-24 18:13 UTC, Aaron Schulz
Use right cvs checking (2.18 KB, patch)
2007-04-24 18:32 UTC, Aaron Schulz

Description Aaron Schulz 2007-04-24 15:11:49 UTC
Currently, the last IP of XFF strings is recorded, this should be changed to the
first one, since the format is:

client, server, server
Comment 1 Aaron Schulz 2007-04-24 15:19:44 UTC
Created attachment 3512 [details]
Patch for ProxyTools

The wfGetLastIPfromXFF() should no longer be used, and this instead for
Comment 2 Rob Church 2007-04-24 15:20:31 UTC
Please remember to add to the CC list when assigning bugs.
Comment 3 Brion Vibber 2007-04-24 15:25:07 UTC
Is this regex meant to match text such as

There's no anchoring at the start or end, so it'll pull the match out of the middle.

More generally, there's no use to pulling only a single item from the XFF line,
as it can't be relied upon unless with intermediate items are trusted. What's
this function meant to be used for, and is there a better way to accomplish it?
Comment 4 Aaron Schulz 2007-04-24 15:30:29 UTC
Created attachment 3513 [details]
Trim, anchor

It is for checkuser. If the checkuser believes any other ones to be
useful/accurate, then they can use those results, rather than just a regexp.

The column is used to search all edits that were made with a given IP acting
behind a proxy according to the XFFs. The trusted ones are highlighted green in
results queries.
Comment 5 Aaron Schulz 2007-04-24 15:58:24 UTC
Created attachment 3514 [details]
Test if each server is trusted
Comment 6 Aaron Schulz 2007-04-24 16:01:00 UTC
Created attachment 3515 [details]
Remove test line, ignore NULL $addresses
Comment 7 Aaron Schulz 2007-04-24 18:13:30 UTC
Created attachment 3518 [details]
Move to checkuser.php
Comment 8 Aaron Schulz 2007-04-24 18:32:42 UTC
Created attachment 3519 [details]
Use right cvs checking
Comment 9 Aaron Schulz 2007-04-24 19:09:41 UTC
Done in r21541.

Note You need to log in before you can comment on or make changes to this bug.