Last modified: 2007-04-24 19:09:41 UTC
Currently, the last IP of XFF strings is recorded, this should be changed to the first one, since the format is: client, server, server
Created attachment 3512 [details] Patch for ProxyTools The wfGetLastIPfromXFF() should no longer be used, and this instead for checkuser.
Please remember to add wikibugs-l@wikipedia.org to the CC list when assigning bugs.
Is this regex meant to match text such as "aklsdjflkjkldsfjfsdsfda1.2.3.4askdflksdjlkf"? There's no anchoring at the start or end, so it'll pull the match out of the middle. More generally, there's no use to pulling only a single item from the XFF line, as it can't be relied upon unless with intermediate items are trusted. What's this function meant to be used for, and is there a better way to accomplish it?
Created attachment 3513 [details] Trim, anchor It is for checkuser. If the checkuser believes any other ones to be useful/accurate, then they can use those results, rather than just a regexp. The column is used to search all edits that were made with a given IP acting behind a proxy according to the XFFs. The trusted ones are highlighted green in results queries.
Created attachment 3514 [details] Test if each server is trusted
Created attachment 3515 [details] Remove test line, ignore NULL $addresses
Created attachment 3518 [details] Move to checkuser.php
Created attachment 3519 [details] Use right cvs checking
Done in r21541.
