Last modified: 2010-05-15 14:35:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 966 - section edit links have problems with HTML header markup
section edit links have problems with HTML header markup
Status: RESOLVED DUPLICATE of bug 2128
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Wikipedi...
:
: 1269 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-30 22:34 UTC by David Gates
Modified: 2010-05-15 14:35 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description David Gates 2004-11-30 22:34:52 UTC
The section parameter of the side "edit" links counts only sections where the
header is visible on the TOC (headers formatted with "==", "===", etc.)
Thus, the "edit" link after the section headed "Keeping headings out of the
Table of Contents" edits the wrong area, as that section contains a header that
is not on the TOC (formatted with "<h2>", "<h3>", etc.)
Comment 1 Rowan Collins [IMSoP] 2004-12-01 03:33:58 UTC
To be honest, I'd say that the "trick" being used to keep these headers out of
the ToC is itself a bug, and that a heading should be a heading and no cheating
by using a different kind of markup. 

However, there does seem to be a long-standing problem with the section edit
code, where the code which inserts "[edit]" links is divorced from the code
which counts the sections for "&section=X" edits. (See also, for example, bug
904, which appears to have been fixed). Without looking at the code, I'd guess
this is because "section counting" isn't done while parsing, but adding the
"[edit]" links is; I wonder if there's some way the counting *could* be done in
the "proper" parser, or made more structurally similar.
Comment 2 Rowan Collins [IMSoP] 2005-01-05 23:51:39 UTC
*** Bug 1269 has been marked as a duplicate of this bug. ***
Comment 3 JeLuF 2005-01-06 00:17:25 UTC
There's a space added before the closing bracket during processing of </h1> HTML
tags.
Changed the regexp in CVS HEAD to also match </h1 >. Some simple test cases have
been solved by this.

Article.php, rev 1.368
Comment 4 Zigger 2005-06-06 13:43:05 UTC
*** Bug 2128 has been marked as a duplicate of this bug. ***
Comment 5 Ævar Arnfjörð Bjarmason 2005-06-09 21:27:37 UTC

*** This bug has been marked as a duplicate of 2128 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links