Last modified: 2011-03-13 18:05:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 960 - in SpecialUserlogin: replace preg_match by isIP()
in SpecialUserlogin: replace preg_match by isIP()
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.4.x
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-30 00:19 UTC by T. Gries
Modified: 2011-03-13 18:05 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2004-11-30 00:19:05 UTC
see title.
I'll patch this with enotif
Comment 1 Brion Vibber 2004-11-30 08:11:25 UTC
It's not using isIP() because it checks if the name *contains* an IP address, not if it is in its *entirety* an IP 
address.

Further, the exact match check would fail due to the order of operations with normalization. That should be 
separately fixed but is not the same issue.
Comment 2 T. Gries 2004-11-30 08:25:23 UTC
(In reply to comment #1)
> It's not using isIP() because it checks if the name *contains* an IP address,
not if it is in its *entirety* an IP 
> address.
> 
> Further, the exact match check would fail due to the order of operations with
normalization. That should be 
> separately fixed but is not the same issue.

Brion:
I thought this is the same (eg. either a name or - automatically by the script -
th IP address. Because I do not understand, what you mean, I propose you write a
small fix, so that I understand the difference.

In SpecialUserlogin.php -- what exactly shall replace the preg_match() call
therein ? Please can you place the "codelet" here ?

( Someone has objected already one time against another similar codepart in
UserTalkUpdate, which was not inserted by me )

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links