Last modified: 2011-03-13 18:06:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 956 - Patch for wfgettype()
Patch for wfgettype()
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Lowest normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-28 18:47 UTC by Joonas Loppi
Modified: 2011-03-13 18:06 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
The new proposed wfgettype() function (5.10 KB, text/plain)
2004-11-28 18:50 UTC, Joonas Loppi
Details

Description Joonas Loppi 2004-11-28 18:47:57 UTC
Copypaste from email:
> img_auth.php
> 
> There is a mention in the comment that this could be probably done better.
> You're right. I rewrote the function and it's now like 10x faster, because 
> regular expressions are slow and now it uses an indexed array. Which is 
> lightning fast.
> 
> http://pompo500.xs.fi/tmp/wfgettype.phps
Comment 1 Joonas Loppi 2004-11-28 18:50:55 UTC
Created attachment 137 [details]
The new proposed wfgettype() function
Comment 2 Brion Vibber 2004-11-29 00:58:14 UTC
I should note that the performance gain is actually very slight; my 
benchmarks show only about a 2% speed improvement in load time 
of img_auth.php as a whole (with Turck MMCache enabled to reduce 
the PHP compilation overhead). That's moving from 30 milliseconds 
per hit to 29 milliseconds.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links