Last modified: 2011-11-29 19:43:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11475, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9475 - MonoBook.php source code too wide
MonoBook.php source code too wide
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.9.x
PC Linux
: Lowest minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-01 15:14 UTC by Dan Jacobson
Modified: 2011-11-29 19:43 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2007-04-01 15:14:17 UTC
What kind of computers do you use to write MonoBook.php? Browsing the
source code is too wide for my screen, and no I don't use a VT100 :-)
"Snob code width snubs One Laptop Per Child kids".

This (inefficiently) finds other long lined files:
$ set $(find * -name \*.php)
$ for i do perl -nwe 'BEGIN{$a=0}
  $a=length()>$a?length():$a;END{print $a,"\t"}' $i;
  echo $i;done|sort -nr
Comment 1 Rob Church 2007-04-01 15:32:16 UTC
Line length is reduced when we refactor or rewrite code. It's a slow process,
but more effective than doing a massive re-shuffle, which causes lots of faux
diffs to appear all over the Subversion logs.
Comment 2 Chad H. 2011-11-29 19:43:48 UTC
It's better now, if not perfect. Marking WORKSFORME.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links