Last modified: 2007-06-06 19:06:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11446, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 9446 - Closing php tag ?> missing in generated LocalSettings.php
Closing php tag ?> missing in generated LocalSettings.php
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.10.x
PC All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 10174 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-03-29 08:44 UTC by Mark Clements (HappyDog)
Modified: 2007-06-06 19:06 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch - closing ?> now present. (631 bytes, patch)
2007-03-29 08:44 UTC, Mark Clements (HappyDog) 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Mark Clements (HappyDog) 2007-03-29 08:44:28 UTC 
I just installed v1.10 from SVN HEAD and the config script omits the closing ?>
tag at the end of the file.

I'm not sure if it matters (I guess PHP closes it implicitly at the end of file)
but I will post a quick patch for completeness.
Comment 1 Mark Clements (HappyDog) 2007-03-29 08:44:54 UTC 
Created attachment 3397 [details]
Patch - closing ?> now present.
Comment 2 Brion Vibber 2007-03-29 14:36:37 UTC 
This was done on purpose, so people don't accidentally add text after it (a
frequent problem).
Comment 3 Mark Clements (HappyDog) 2007-03-29 21:22:08 UTC 
Ah - I see.  Clever.

One day I'll submit a patch that's actually useful... :-)
Comment 4 Raimond Spekking 2007-06-06 19:06:16 UTC 
*** Bug 10174 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links