Last modified: 2014-11-18 18:07:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9416 - Spam blacklist match should show error above edit box during preview
Spam blacklist match should show error above edit box during preview
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Spam Blacklist (Other open bugs)
unspecified
All All
: Low normal with 6 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 7576 16757 17683 17903 20548 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-26 08:01 UTC by Tisza Gergő
Modified: 2014-11-18 18:07 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2007-03-26 08:01:39 UTC
When an edit matches the spam blacklist, the following texts appear in the
message: MediaWiki:Spamprotectiontext, MediaWiki:Spamprotectionmatch with the
matching link as $1, and MediaWiki:Returnto with the Main page as $1. The last
one is wrong, and can result in lost edits. There should be a
javascript:history.go(-1) link, if any, so that the editor gets back to the text
he entered but couldn't save yet.
Comment 1 Brion Vibber 2007-03-26 13:56:29 UTC
Changed summary to clarify.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-26 14:03:17 UTC
Why doesn't the message just appear above an edit form with the entered text, as for failing to 
enter an edit summary or whatnot?
Comment 3 Rob Church 2007-03-26 14:48:43 UTC
(In reply to comment #2)
This might require altering how MediaWiki provides filter hooks for extensions,
but I think it would be worth it.
Comment 4 Brion Vibber 2007-03-26 14:52:03 UTC
Shouldn't require altering, since that's already how the captcha works.

The old spam blacklist was originally meant to be as vague and mysterious as
possible so spambots would find it hard to tell what happened, but that just
annoys people.
Comment 5 Brad Will (tmbw.net) 2007-05-09 14:50:20 UTC
Same issue as #7576
Comment 6 Omegatron 2007-09-22 13:21:30 UTC
This is causing people to lose work.   See http://en.wikipedia.org/wiki/MediaWiki_talk:Spam-whitelist#Without_warning.21

(Yes, the actual problem here is using the spam filter to block sites for editorial reasons, but that's beside the point...)

What *should* happen:

If you enter a "spam" link, and press "preview" or "save", it should just give you the normal edit window with the spam warning above it, so you can remove the offending link and continue.
Comment 7 Tisza Gergő 2007-09-22 15:31:59 UTC
I've heard that complaint for the block notification, too.
Comment 8 Tisza Gergő 2008-01-06 01:21:50 UTC
Another problem that would be solved by handling spam filter hits similar to edit conflocts is when the user edits a section, and the spamlink is in another one. Even if he uses the back button, he won't be able to find the link he was warned about; the only solution is to copy his changes to a text editor, return to the article, open the whole for editing, find and remove the spam and copy the changes back from the text editor... confusing even for regular editors.
Comment 9 Marco 2008-11-08 16:46:46 UTC
*** Bug 7576 has been marked as a duplicate of this bug. ***
Comment 10 Mike.lifeguard 2008-11-14 01:23:21 UTC
Is there any reason this is technically difficult to implement, or is it simply that nobody has bothered?
Comment 11 Stifle 2009-05-05 08:39:10 UTC
I concur with this issue; people with poor browsers that don't keep form fields on the back button are losing work over this. Displaying the edit window would at least allow them to copy what they tried to add to a text editor and save it, if nothing else.
Comment 12 Splarka 2009-09-08 23:59:30 UTC
*** Bug 20548 has been marked as a duplicate of this bug. ***
Comment 13 Splarka 2009-09-09 00:00:29 UTC
*** Bug 16757 has been marked as a duplicate of this bug. ***
Comment 14 Splarka 2009-09-09 00:00:51 UTC
*** Bug 17903 has been marked as a duplicate of this bug. ***
Comment 15 Splarka 2009-09-09 00:01:33 UTC
*** Bug 17683 has been marked as a duplicate of this bug. ***
Comment 16 Dan Jacobson 2009-09-09 00:15:21 UTC
Why just the other day I added this
message where I mention to the poor user to use his BACK key, and then save his work elsewhere,
lest he follow the link which will appear below this, and blow away his work.

$wgFilterCallback='JidanniTitleFilter';
function JidanniTitleFilter($mTitle){
  if (preg_match("/^\d/", $mTitle->getText()) && $mTitle->getNamespace() <= NS_TALK) {
    EditPage::spamPage(
		       '***請退("←"鍵),另存所打的字,然後見「首頁」=>「使用說明」中之「頻率編入其單位」。謝謝。***');
    return true;} return false;}
Comment 17 Waldir 2009-10-21 09:36:39 UTC
(In reply to comment #10)
> Is there any reason this is technically difficult to implement, or is it simply
> that nobody has bothered?
> 

It's been almost a year since that comment, and noone has clarified the situation. I'm interested on that answer too, and I believe many other commenters are as well. For reference, here's another discussion about the user-unfriendliness of this behavior: [[MediaWiki talk:Spam-blacklist#We should be able to point to blocked links in talk pages]].
Comment 18 Helder 2011-02-03 16:37:08 UTC
(In reply to comment #17)
> (In reply to comment #10)
> > Is there any reason this is technically difficult to implement, or is it simply
> > that nobody has bothered?
> > 
> 
> It's been almost a year since that comment, and noone has clarified the
> situation. I'm interested on that answer too, and I believe many other
> commenters are as well. For reference, here's another discussion about the
> user-unfriendliness of this behavior: [[MediaWiki talk:Spam-blacklist#We should
> be able to point to blocked links in talk pages]].

Two years now.

Another user has also reported on Portuguese Wikipedia the need of such error message **during preview**:
http://pt.wikipedia.org/wiki/WP:CP?oldid=23748093#Defeito.3F
Comment 19 Helder 2014-05-18 13:33:26 UTC
This is now worse due to VisualEditor:
* Clicking on "Save page" causes Spam Blacklist to say I'll lose my work unless I use the back button
* Then it says I will lose the content if I use the back button!
There should be an option not to lose the work.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links