Last modified: 2007-06-05 15:03:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11383, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 9383 - Incorrect field type in database patch
Incorrect field type in database patch
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
unspecified
PC Windows XP
: Normal critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-03-22 17:23 UTC by Thomas "Tango" Dalton
Modified: 2007-06-05 15:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Fix incorrect data type in patch-rc_deleted (989 bytes, patch)
2007-03-22 17:27 UTC, Thomas "Tango" Dalton 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Thomas "Tango" Dalton 2007-03-22 17:23:56 UTC 
The database patch "patch-rc_deleted.sql" has an incorrect data type which
causes update.php to fail. I have a patch to fix it, but no commit access, so
I'll just upload it here.
Comment 1 Thomas "Tango" Dalton 2007-03-22 17:27:24 UTC 
Created attachment 3377 [details]
Fix incorrect data type in patch-rc_deleted
Comment 2 Rob Church 2007-03-22 18:09:50 UTC 
"BLOB" is a valid column data type, although it can't have a default value in
MySQL strict mode.
Comment 3 Thomas "Tango" Dalton 2007-03-22 19:27:58 UTC 
Does it need to be a BLOB? If so, we can just remove the default.
Comment 4 Aaron Schulz 2007-03-22 20:28:00 UTC 
rc_params is defined exactly the same as log_params. Odd.
Comment 5 Rob Church 2007-03-26 23:22:49 UTC 
(In reply to comment #4)
> rc_params is defined exactly the same as log_params. Odd.

MySQL won't accept a default value for a BLOB column when operating in strict
mode; patches aren't split up to cope with the three schema variants we offer.
Comment 6 Rob Church 2007-06-05 15:03:35 UTC 
Fixed in r22760.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links