Last modified: 2012-10-15 04:37:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9293 - <noinclude> edits in templates should not be submitted to the job queue
<noinclude> edits in templates should not be submitted to the job queue
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Templates (Other open bugs)
unspecified
All All
: Lowest enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-15 00:15 UTC by Yonatan Horan
Modified: 2012-10-15 04:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yonatan Horan 2007-03-15 00:15:10 UTC
After making a dumbass mistake on commons by editing a high-use template for a
stupid reason (and raising the job queue to an unreasonably high number), I
figured these sort of mistakes by dumbasses could be avoided in the future.

It'd be nice if someone made a patch that ignored edits when they were done to
an area of the template that  was between a <noinclude> and </noinclude> (or if
the edit itself added <noinclude> to the template). I'm not too much of an
advanced programmer but I figure a check should be made in the diff text before
the request is sent to the job queue to see if the edit was made in a
non-included area.

Also, I'm not sure if this warrants a bug report so if it does please split
this. I accidentally edited the template (a high use one as previously
mentioned) three times because all three times the template page didn't load
after the edit took place (I got the standard wikipedia is down message, the
edit was on commons though).

Of course not being stupid would be a better fix but that's uncurable. ;/
Comment 1 Yonatan Horan 2007-03-15 04:49:59 UTC
To clarify the above, other edits were going through fine at the time (edits to
other commons and wikipedia pages).
Comment 2 Brion Vibber 2007-03-15 04:52:51 UTC
cf bug 8322
Comment 3 Hendrik Lönngren 2007-12-19 09:23:20 UTC
Is bug 8322 really related to this one? I mean, here we have the opposite problem: Job queue submission reacts on every change to the template, not just a change in the preprocessed source (for transclusion), isn’t it?
Comment 4 Aaron Schulz 2008-05-16 20:09:21 UTC
Too much of a special case check. This is an easy way to end up with errors and unmaintainable code.
Comment 5 Brion Vibber 2008-05-19 16:20:00 UTC
What you could do is run the extractions on the old and new versions of the page, and only submit the updates if there's a change.

In theory, that should work reasonably reliably.

In theory. :D

It doesn't sound like _too_ evil a hack, and avoiding spamming the job queue would be nice.
Comment 6 Aaron Schulz 2008-12-28 04:48:43 UTC
(In reply to comment #5)
> What you could do is run the extractions on the old and new versions of the
> page, and only submit the updates if there's a change.
> 
> In theory, that should work reasonably reliably.
> 
> In theory. :D
> 
> It doesn't sound like _too_ evil a hack, and avoiding spamming the job queue
> would be nice.
> 

This is done already.
Comment 7 Mark A. Hershberger 2011-03-13 17:46:08 UTC
Changing all WONTFIX high priority bugs to lowest priority (no mail should be generated since I turned it off for this.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links