Last modified: 2011-03-13 18:06:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11260, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9260 - ExtensionLoader needs updating to work with current extension conventions
ExtensionLoader needs updating to work with current extension conventions
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Lowest major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-12 12:17 UTC by MrPete
Modified: 2011-03-13 18:06 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MrPete 2007-03-12 12:17:20 UTC
...and can't be fixed.

ExtensionLoader loads other extensions from within a function.
It pulls in existing global var declarations, but (of course) cannot force new
declarations to be global.

That means any globals defined at global scope of extensions will be broken,
which means many extensions can't be used with ExtensionLoader...

I just discovered this the hard way with Lockdown, but it applies to several others.
Comment 1 Rob Church 2007-03-12 13:13:14 UTC
ExtensionLoader dates back to a time before the current extension framework
(special pages, in particular) became the widespread norm. I expect it's out of
date and needs rewriting or removing; installing extensions isn't exactly
neurosurgery, and anyone who can't do it has no business pretending to be able
to administer a web application.
Comment 2 MrPete 2007-03-12 16:23:22 UTC
I recommend removal. It's pretty simple to replace the extensionloader paradigm
with straight code. I did just that to get our site working.

ExtensionLoader version:

 require_once('extensions/ExtensionLoader/ExtensionLoader.php');
 wfExtensionLoader(
   '../CharInsert/CharInsert.php',
   '../Cite/Cite.php',
   ...
   );

"Raw code" version:

 require_once('extensions/CharInsert/CharInsert.php');
 require_once('extensions/Cite/Cite.php');
 ...
 
If anything, the code is simpler and more straightforward without this extension.
Comment 3 Siebrand Mazeland 2008-08-11 17:10:14 UTC
OBSOLETE since r39155. WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links