Last modified: 2011-07-07 07:54:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9246 - When uploading a new version of a file watch this page is not automatic
When uploading a new version of a file watch this page is not automatic
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-03-10 21:43 UTC by Robert Leverington
Modified: 2011-07-07 07:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Proposed patch (709 bytes, patch)
2007-04-20 20:17 UTC, Max Semenik
Patch that fixes this bug (1.22 KB, patch)
2008-01-26 00:19 UTC, Robert Leverington

Description Robert Leverington 2007-03-10 21:43:56 UTC
When uploading a new version of a file the 'watch this page' check box is not
automatically checked if you are already watching the page already.
Comment 1 Max Semenik 2007-04-20 20:17:15 UTC
Created attachment 3478 [details]
Proposed patch
Comment 2 Raimond Spekking 2007-04-25 10:48:38 UTC
(In reply to comment #1)
> Created an attachment (id=3478) [edit]
> Proposed patch

Patch tested, but in consequence I expect that unchecking the 'watch this page'
check box the page will be unwatched after reupload. This doesn't happen with
this patch.
Comment 3 Brion Vibber 2007-04-25 20:02:40 UTC
That behavior would match editing behavior, so that's fine.

Or... do you mean it won't happen, but you would expect it to, so the patch is
incomplete? Hrmffffllll
Comment 4 Raimond Spekking 2007-04-25 20:06:03 UTC
It does not happen, the patch is incomplete.

Comment 5 Robert Leverington 2008-01-26 00:19:53 UTC
Created attachment 4581 [details]
Patch that fixes this bug

This bug is based upon the previous patch but also acts upon an unchecked watch state.
Comment 6 Robert Leverington 2008-01-26 00:38:08 UTC
Fixed in r30162.
Comment 7 Brion Vibber 2008-01-26 00:55:57 UTC
Reverted in r30163.

A problem with this is that it *un*watches a previously watched image under the following circumstances:

* 'watch pages I edit' is not enabled (eg, default state)
* go to Special:Upload and select the file
* hit 'upload'

The initial check state is unchecked (since there was no initial destination name set), and this doesn't get updated to reflect the existing watch state of the previous image.

There are a couple possible ways around this. One is to compare the form's actual initial check state with the submitted check state and only apply an unwatch if there was a difference.

Another might be to do a watch state update via AJAX when a new destination filename is set in the form. This would allow the checkmark's default state to be set 'properly' for those with JS enabled in modern browsers.

Perhaps a combination should be used. 
Comment 8 p858snake 2011-04-30 00:09:36 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

Note You need to log in before you can comment on or make changes to this bug.